[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/11] xen/arm/irq: allow eSPI processing in the do_IRQ function
- To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Leonid Komarianskyi <Leonid_Komarianskyi@xxxxxxxx>
- Date: Wed, 27 Aug 2025 10:00:15 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYXxoh3qHo5hDPEzIBoDr1aAOskWc1JrOTShlUitBDY=; b=oZ7ybbnwKluqChb1K3Jwy8iQY97ReoL/RIOZJnUJAKyH9ZCYirTjNqEgV6X4zPAsdLmyDZo07uZvO+xpFKXmd0yvpYldIjU8z+nVweD9cQ/FSyY/I6s5Dpdj/cqeuB4JjrChhmtV1Zysl1CEX/8fGcXH+EkfW3US/bX0bvqKwPMRE1Ex6DPBQ75hw4ziN5mJ17t5dtUqW/5V2iT3qVXh9IYStcsNvCm8pvL8Hx6ty3zsSu+bp2W8KNFHZ9FPbgny0yoP4Dj1X+GZk/jb+E6ElFZeh/GO6gTJjXs68Iz6UBrKE8xzC5rtwb+v6QGh0YtGTeUSCL71aX4JAjBNtRXShw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qAfpmfY3HAgyNPHWskW4x6FN8Bivtr6BqtOZRxnCnMxrOZLIRS96hKNFR59qgGMglOcCGVlLa8ggQk+aLDSHIU62jUnP7TJ9uk5pMUVguom/bpueDwaOk3rM1iDReogcecTbSCdbi8nJ5GCp/sLX/imDFBuUvMxAKUbruEU/FL+Hgqzr0LOIq88arqHj253AJEdvwo5NFJJ+NTjo/3634sk6McDwwaUCMT4h8a5OTTpTAgrbZxHWWncxtMPqY81nWzNHdjrI+c4pOBhi71Ab8R/jMNIQB9lAc+PiK6+w9C3MRwK0rZbR7Uc0MvArdb3T0ZYIS1i2FvnZDNPvcGRwFA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "olekstysh@xxxxxxxxx" <olekstysh@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 27 Aug 2025 10:00:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcFpJ/78TDbVIRnkOE9iNbqduJVLR2RaCA
- Thread-topic: [PATCH v3 06/11] xen/arm/irq: allow eSPI processing in the do_IRQ function
Hi Volodymyr,
Thank you for your review.
On 27.08.25 01:30, Volodymyr Babchuk wrote:
>
> Hi,
>
> Leonid Komarianskyi <Leonid_Komarianskyi@xxxxxxxx> writes:
>
>> The do_IRQ() function is the main handler for processing IRQs.
>
> but you are making change to gic_interrupt() function... I think you
> need to update the commit message and subject.
>
>> Currently, due to restrictive checks, it does not process interrupt
>> numbers greater than 1024. This patch updates the condition to allow
>
> But check reads "irq < 1020"...
>
>> the handling of interrupts from the eSPI range.
>>
>
> With commit message fixed:
>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
Oh, yes, my mistakes. I will update the commit message in V4.
>> Signed-off-by: Leonid Komarianskyi <leonid_komarianskyi@xxxxxxxx>
>>
>> ---
>> Changes in V2:
>> - no changes
>>
>> Changes in V3:
>> - no changes
>> ---
>> xen/arch/arm/gic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
>> index b88237ccda..634b77c987 100644
>> --- a/xen/arch/arm/gic.c
>> +++ b/xen/arch/arm/gic.c
>> @@ -341,7 +341,7 @@ void gic_interrupt(struct cpu_user_regs *regs, int
>> is_fiq)
>> /* Reading IRQ will ACK it */
>> irq = gic_hw_ops->read_irq();
>>
>> - if ( likely(irq >= GIC_SGI_STATIC_MAX && irq < 1020) )
>> + if ( likely(irq >= GIC_SGI_STATIC_MAX && irq < 1020) ||
>> is_espi(irq) )
>> {
>> isb();
>> do_IRQ(regs, irq, is_fiq);
>
Best regards,
Leonid
|
