[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/dom0less: mark domain_p2m_set_allocation __init
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 14 May 2025 09:04:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fg0IjlIRNUhsid3cs7IM2WM++hYVZQNpG3ftDcxV+gU=; b=QIuE6om7Huki+FPXeLy1iY75yBztjVORVnz9TscnhP1nwzyiOIQsfk+Ky5KMknZJVMfS6sHt8b6arqomRuzk9yq2X74schgM91xy0MzA8YO7gCkmJ+RRl/Ge71uWPkN9MfNeG7flYFh6B82ku+Q/AYJg7PpKNszcwKan6p+frhM5B6Z/BPnTDPfhOiL77+Qpwc2J2XPBvuNfodtoKSbZTzZE9tsyFF8r11JVE5yCE1VVCZwGZ+QKSwv7+Pda/RlZNcPiLqU2VYsUzqG9iZijY7Pb3oPdNBs+YeMx/Tous2eewHiZWssk5ugxR+xJwEj/AKtamxKyH+raNk0HlOaUMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fNVlcYSA+K0gGeswZCedrNU2Iv7Tz3T4fru48X1p2MFNgZOjfxlViGBDhyihTcByZOQDISSIJOT4n1NFkc1K4YDtP8yK2ulTboNOWZaiyi9vwpxAI1YCsY74aritVHPvrBY6M5rWyge6S0KWwTRP8RlBZdnu9XsfZ9y1QtP0FBFLfWZdzKnLM8h0atVz2rbvgsYWUzaLKvdOU1U0v17YUBxmTSZBdUjU18QLTmnF6AM5DRbtQlV5mR3VLrw0XhhMYepx3XpSGv7NGuAfVoExTc+A1bqEQxJqGdItmZ9kCeqPBVcjsFh8ZY8teYqPB6elPMWCej5Q4tFd3JzPxibHRw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Delivery-date: Wed, 14 May 2025 07:04:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/05/2025 08:56, Jan Beulich wrote:
> On 14.05.2025 08:31, Orzel, Michal wrote:
>> On 14/05/2025 02:07, Stefano Stabellini wrote:
>>> On Tue, 13 May 2025, Stewart Hildebrand wrote:
>>>> All functions in dom0less-build.c should be __init.
>> Why? This patch is first in your series and by that time there is no build
>> time
>> enforcement. Together with the Fixes tag it implies that this is somehow an
>> issue (i.e. build/runtime issue) other than inconsistency for which we surely
>> don't need Fixes tag.
>
> I disagree: Code not called post-init should be in .init.*. While not formally
> a Misra violation (and wrongly so, I think), it imo effectively is: Such code
> is otherwise unreachable post-init.
You have a point here, I agree. Although I don't think MISRA differentiates
between unreachable in general vs pre or post init. It defines it as code that
cannot be executed. It does not go into stages of runtime execution.
I'm thinking how this is different from a function that is called e.g. only once
at specific point at runtime execution for which we did not come up with a
separate section?
~Michal
|
