[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/3] xen/dom0less: refactor architecture-specific DomU construction
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 14 May 2025 09:08:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XSug5UFo8aZiLYMizIuP0bAvaM6rQ3x7gEg8lrds+z4=; b=xVZRO9TSPVvpbX5h+ASjU9LgmS+TvOS81lruG5Wb5etiYj79ugYy0dDgaaVaPnbSOYuhp52jWgEhQWfCXHnt0p5GhsAaw0qp40iN1CsyT4HTS4l/gbZw+umGIhnBOj8Ck0FA7VclYuZpHdzJZ439Nf6SfNDPASAurlwTavDmUDewNAsNRmosGxianVXyzUMdwg4BVW8ChpiLgrhJ89VQxVanhuGCRSOlCtFwewcbr4X6P6fQ9/HbORtufwRMp4lS279rf7YIZ8H3opt4mY/dXxTRuGqASEKl3C135eZ/QvK8qlQStcYaePRft0hF+vFS+5KnhlnI+QJvSLLgNw+EFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iWo8yapL69qsgNiC8m+AAg+50ORynp00Hxr6yI4xbGZgwHmHkQNqxIcXOs6jbCU20bZTKuJsDh8uEm85mkam4gV03G7JVkRnJTCkUc1oYNW+t5Qf6YTw/pVcNrEzHXi6q/Lmz5C7LtZM9FfRDZJ1A6exzaQ6UK7tUEy60E1Tzh+pDEbkQnxkvNttssgcdOdnNeopfimv3hzdAE5sGhF4XcmzfTNL4MY0AF+A7nAZbPqKmP6CbWXqDR3UkkD/rdi7RhnBlOnR+BZwnSn+YOY4lytkiUfyC37r3dujdhmaPT3A9cEz769dGkSxrDFS9jdVe0ZvMF/AWis8lWi4xwkR1Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 14 May 2025 07:08:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/05/2025 16:29, Oleksii Kurochko wrote:
> Refactor construct_domU() to improve architecture separation and reduce
> reliance on ARM-specific logic in common code:
> - Drop set_domain_type() from generic code. This function is specific
> to ARM and serves no purpose on other architectures like RISC-V,
> which lack the arch.type field in kernel_info.
> - Introduce arch_construct_domU() to encapsulate architecture-specific
> DomU construction steps.
> - Implement arch_construct_domU() for ARM. This includes:
> - Setting the domain type for CONFIG_ARM64.
> - Handling static memory allocation if xen,static-mem is present in
> the device tree.
> - Processing static shared memory.
> - Move call of make_resv_memory_node() to Arm's make_arch_nodes() as
> this call is specific to CONFIG_STATIC_SHM which is ARM specific,
> at least, now.
>
> This cleanup avoids empty stubs on other architectures and moves
> ARM-specific logic into arch code where it belongs.
>
> Also, don't loose a return value of functions called in
> Arm's make_arch_nodes().
>
> Suggested-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks, it looks better now.
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
possibly with the remark from Stefano fixed.
~Michal
|
