Re: [PATCH 1/2] xen/dom0less: mark domain_p2m_set_allocation __init

["Orzel, Michal" <michal.orzel@xxxxxxx>]

On 14/05/2025 02:07, Stefano Stabellini wrote:
> On Tue, 13 May 2025, Stewart Hildebrand wrote:
>> All functions in dom0less-build.c should be __init.
Why? This patch is first in your series and by that time there is no build time
enforcement. Together with the Fixes tag it implies that this is somehow an
issue (i.e. build/runtime issue) other than inconsistency for which we surely
don't need Fixes tag.

Same for the second patch.

>>
>> Fixes: 2705f1adb9df ("xen: introduce Kconfig ARCH_PAGING_MEMPOOL")
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 
>> ---
>>  xen/common/device-tree/dom0less-build.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/common/device-tree/dom0less-build.c 
>> b/xen/common/device-tree/dom0less-build.c
>> index 2c56f13771ab..39cb2cd5c70e 100644
>> --- a/xen/common/device-tree/dom0less-build.c
>> +++ b/xen/common/device-tree/dom0less-build.c
>> @@ -730,8 +730,8 @@ static int __init domain_p2m_set_allocation(struct 
>> domain *d, uint64_t mem,
>>      return rc;
>>  }
>>  #else /* !CONFIG_ARCH_PAGING_MEMPOOL */
>> -static inline int domain_p2m_set_allocation(struct domain *d, uint64_t mem,
>> -                                            const struct dt_device_node 
>> *node)
>> +static inline int __init domain_p2m_set_allocation(
>> +    struct domain *d, uint64_t mem, const struct dt_device_node *node)
>>  {
>>      return 0;
>>  }
>>
>> base-commit: 5873740e41acb8593f92623ddd03caebda2718f6
>> -- 
>> 2.49.0
>>

~Michal