[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] xen/arm: static-shmem: Drop unused size_cells
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 3 Mar 2025 09:10:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBmWDJFmfIyfZcTv14kRHtT+JnzsA3gF2Ynvbi6vSVQ=; b=CW4/ZZzFV9CuVprWOGHRJhIdGEbrpS1YqJ5Q6YyuscDVZaXWWaWTv5+UT9n4N2P3wAfRjiZx1bZ02TzSsWoOkakTAO88PNfHN+vJJm9lS4cwTGIt/dKAtRSzZwPItTJjkcjZOWmuIEdDYrCdIAj/Nw7htblH5GJrYhzCebnRWsW+JT3as9eTAP4zp4U1tUNvGO1lxM8zmcmHCdjj0YO9DKyy5Ld3OBWBtuJEqunqx1PYkiVeKMJVn3yPQVRn9pW0BVqH06GFxkEn0NtSb5R9lI9LoHDaoqUalgcG9Qxd/9X/eI9Ftogvv2P/oNABxkfNIX19dkd6DhKc7cfR03aiGA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBmWDJFmfIyfZcTv14kRHtT+JnzsA3gF2Ynvbi6vSVQ=; b=VOyIm6AnmutQ5+kBMXn6Ns7jzo4S8Tyo8LldsVdapO1xTlYos7O3eMsRCN+YQwBx3ls/x5kRGL59UT3oLBslx2AdFQ72lzFtcdWMFCFOkz3C4Ugy9HAlFyiu45zR8g7PEDW5F1vD5ZUK3Tb7T2yS4DWV4WCSNaTxFjd8Lpz7bqlXGiQ+zth5NmnRyhk8KTVDLLr+KsTqNmFHHRR8BsTj2J39RWjgvoEZAtgUm6bCy7qGdDZue+82VBtvL4cuIPN5/09rxNaKewWzffqc5iFk5V3eNKVtD8whXQef086LQnNcg9NXR4ml2JpHBbctsOwMz1RcaO75kNOR159Cav3/4Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=n4RIsEOW9gtIF9maeHjmfYjYrAMjkCB+y2QbFiqJt8EUgP4T0b041Gb/wXEGTn7JNPpJmoqXl6Z1ByHT/D2Nk8bo4MtYACx+53dooXdiGJXO8DLVVTx11/ZG6aKXoruM45aRhyV9R4YQQxz3XroRJA16OdfMccSWdKg4MSMrh5T3BkrWB+ZGyeMZjQPr5eih9rXERH+f+TqvPVep+TjZ/dWb+eyz3GyhWX5ufR/GUzMXxSGPJdujiBb9Jw6hqQ3uGT/BQ1bvtdGxHRCfcAY2T4xI2ojBK7JvzOx3x9qlTPyRDgzvzgNKd14OCmyXIS9CW42CuqnnC80msK54XaEesw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l0pUSH6nXLKMQaUHxMRHUVrTEqGdLYaMP5U8ArbMK+BJ44ADN4dy6BtgF2ZOFss1OT8Y7VcyjN381xrarlTvTLrIElUS4t+KhfsJaCEgoaB1sBGMajL4RqmRBMu+GhZiXoApUPOhi/UCHUZ7HqrOHEu1Iro7gYnSz4GIsahZzDE8esKGG8VfLu/pLhrxtZnCCCRMlp2IOBQkAuC2qQ7RM0QC5kazmc+ZGOTdGklLm21Ke7XxqYCXoUnRWvGoWJLA6cj1bU6/WtLdoTWYdTVwCoQSFZDMiIJYwdZ4i0ca7If7WArgjOP9zYzwfCqUOTLO1dY3IQ1j0GJnFcRoMJOeoQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 03 Mar 2025 09:10:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbjBo8nuO52Rl5EECHrCznAwnruLNhIAWA
- Thread-topic: [PATCH 3/4] xen/arm: static-shmem: Drop unused size_cells
Hi Michal,
> On 3 Mar 2025, at 09:56, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Value stored in size_cells is never read because we're only interested
> in retrieving gbase address of shmem region for which we only need
> address cells.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/static-shmem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/static-shmem.c b/xen/arch/arm/static-shmem.c
> index 8f87154c3587..c74fa13d4847 100644
> --- a/xen/arch/arm/static-shmem.c
> +++ b/xen/arch/arm/static-shmem.c
> @@ -302,7 +302,7 @@ int __init process_shm(struct domain *d, struct
> kernel_info *kinfo,
> const struct membank *boot_shm_bank;
> const struct dt_property *prop;
> const __be32 *cells;
> - uint32_t addr_cells, size_cells;
> + uint32_t addr_cells;
> paddr_t gbase, pbase, psize;
> int ret = 0;
> unsigned int i;
> @@ -338,7 +338,6 @@ int __init process_shm(struct domain *d, struct
> kernel_info *kinfo,
> * pbase is optional.
> */
> addr_cells = dt_n_addr_cells(shm_node);
> - size_cells = dt_n_size_cells(shm_node);
> prop = dt_find_property(shm_node, "xen,shared-mem", NULL);
> BUG_ON(!prop);
> cells = (const __be32 *)prop->value;
> --
> 2.25.1
>
|
