[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] xen/arm: Don't blindly print hwdom in generic panic messages
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 3 Mar 2025 09:11:22 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrEXBmqtB2OL9PYLmDwtUZ3XLsOvcPaENUy9zLZo234=; b=N2+HZuGrWafembRFs6DPYXmgqUEvs9fbbgkZzJ8norTJlg9DDSuadtag0QOQMmL16oncX/yDjrWYOr9feXMmkDWi/gbiTcDAqU1qecjHjPLIVjG1scuT1GckE9L+UnqOWSTv2X12kZ1hWoEbg+fE/nVT/kh46UnM8ZHYWp2ADhwrHRi/SkgkGEeUkHOuTfUpWvza2jK7Kd/4RnRW/T5H2i6T4a30JosofZ1Vono8H0fxp4SKOujrnRUBax+DmUFPQ+aOVC8EawrTVqKsUZnQGSXAZ7RX/A5vuKJAP7CoL/4I2fTqczyaHtz0knPzgBKHn19K5yKZOHIMzv4+wIswcA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrEXBmqtB2OL9PYLmDwtUZ3XLsOvcPaENUy9zLZo234=; b=ER9oZzw939yaCQ3iU1hPvakqEoAPVwms2u/O8iOAQ5fp/V96BmXIgiIxFXWm2i7Onu9joXEWLgn60w6yxNs4tOJPycCp9sp9nhpPyV+G/4nZhLSdnrq7UnwSbdJPhcIyBApaR0iV5HtRvEa3GhIzs4YeBl5NTu0XNk9Ec/Y1SPixWlzKhA2ZPhTb5a6OBoM24/iDtJqGIpsAC+lL4wJyb/oBqKCsqCg1jlgB9eJm9zZG68abBrMWorgiJ+hSni0Ca+6IUC4ISFWqArZcLISUIJxBXn84fiQuOteNC3AMaYreNropGIsUTj+CEH9nekWleuoaomwCgaQCK9synQQABA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=A/RevZ6QtMAWN4eajEXDslFZIOeQa3C+Qlvur7322C0XJ2eW0F3WRHq4u06rOGKgH6q2TbEMYM7UMEUsRpwvPlMHsL3dik3p0raaZhbZ2+L13aJo/NU0oYP5ezc0LapmHKuThU2EX+bW6WzIQjLkx10wZnBXFicqs1KzGSwvyAjsih5tuRq6bw3BmAMFCAhPH3h4S/a1SpksaACMJgZrwB2tjaN6D8pO//W96GFa4e6yfPO0Tr1lvFb7vzhua+XEjXhYshzexiO2MZvyiqmlg+4Gco11gNfIGq5GqRnjAi3Eb0jofQ4A3XDth1y2HjuE4uey2tFwKpRJut73DJWvEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vZtmV8L81wMuKSHEVshBY0LGva+BAkzFvmYZ3IzBFU/WTMpAimpGmSF/EII/SJi2Y/62umfwSms1ncxFjFgnFhctLIHhs6z0NXk9Hs9/eFJcCOnfoiPLMk46zZ6OyAzykjfz+vsbnI5cYb2EP6igMk30xmu9zGc+0hy/QlVE5YDLyKPvQWedDvOPun50w+ldPHEa2vO2u3G0CIzk5P0mUO8yl3YECrOmLdLm6NmHYoKsJgF6Kv0H6M1aUs6TkYlO0k5F1/uuZsNscIw3Oq9ZCo/tbxxDe5sgXZ/2sqJPM+c2wvk7/9uJP2cHBp1L6Hkul12TVmZzPqmw1JTUaFv5OA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 03 Mar 2025 09:11:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbjBo/T2YeCrZVnUCj55dU9yGL9rNhIDYA
- Thread-topic: [PATCH 4/4] xen/arm: Don't blindly print hwdom in generic panic messages
Hi Michal,
> On 3 Mar 2025, at 09:56, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> These functions are generic and used not only for hardware domain. This
> creates confusion when printing any of these panic messages (e.g.
> failure when loading domU kernel would result in informing a user about
> a failure in loading hwdom kernel).
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/domain_build.c | 4 ++--
> xen/arch/arm/kernel.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index fe05cf6d855f..6531fe019f79 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2112,12 +2112,12 @@ static void __init initrd_load(struct kernel_info
> *kinfo)
>
> initrd = ioremap_wc(paddr, len);
> if ( !initrd )
> - panic("Unable to map the hwdom initrd\n");
> + panic("Unable to map the %pd initrd\n", kinfo->d);
>
> res = copy_to_guest_phys_flush_dcache(kinfo->d, load_addr,
> initrd, len);
> if ( res != 0 )
> - panic("Unable to copy the initrd in the hwdom memory\n");
> + panic("Unable to copy the initrd in the %pd memory\n", kinfo->d);
>
> iounmap(initrd);
> }
> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index 80fad8b3362c..6eaf9e2b06b3 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -150,12 +150,12 @@ static void __init kernel_zimage_load(struct
> kernel_info *info)
>
> kernel = ioremap_wc(paddr, len);
> if ( !kernel )
> - panic("Unable to map the hwdom kernel\n");
> + panic("Unable to map the %pd kernel\n", info->d);
>
> rc = copy_to_guest_phys_flush_dcache(info->d, load_addr,
> kernel, len);
> if ( rc != 0 )
> - panic("Unable to copy the kernel in the hwdom memory\n");
> + panic("Unable to copy the kernel in the %pd memory\n", info->d);
>
> iounmap(kernel);
> }
> --
> 2.25.1
>
|
