[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] xen/arm: Check return code from fdt_finish_reservemap()
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 3 Mar 2025 09:10:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jnIFs8/rEBOiAcmY9FHzogK8jWg/5s0O8QhB1ONh5+o=; b=BVPgboZcSbQth5tPwrArnBbP6ZXUi9+sVSB2+zfFQ9HqIqVVAnRyZ6y93F+UqQnVqb7ccmk92wVj7ZC3aAX+oyer9AFBXFs9yHo9EM3tZXdOZwyfVJQYHFT+ap73j/4Dj62DIn9Y/YuS5h4VRs20G5km/hnOHjyKRkdqc4UDHw+XvLIhv98fL0lcqVcCUA1+Ecu+fbho0nMWgWLIsWzj+PpxNpBCr0hI8B4Imu3G2/O5uso8Q95chU+sCaHQVOBHCQsYnp0mWWODJZQnt/BMlOtgaO/dQjVw8jkjLJcyEScfYjti02ABfD8q4mCvuahrJYN/zwCN6DSvh2MQtN+TVw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jnIFs8/rEBOiAcmY9FHzogK8jWg/5s0O8QhB1ONh5+o=; b=rdwokJKQPpl56YvZpCAemVnXm9emEGSFUYaSh8rGl7AVfaYFk4uF6vuqesU2oiFRX0163Z6SG3pLV9BaGSQh1hgLZEFQkCKjr5HC4s1sKV7p7esUOhSm0XSawz0ZgCXfY+Vf0SzVXAf932CDWmQyBzGQigkJYZTuddnukNAYruAiiAFOawIjpp20VvfBllplEhVZZWYtoDR9kqFe8S0rNjXd0w8euzZGVcKQl62UqESLo64bbgaeCD3JKQnzRL5KHfALgAFOh3qCyyDZUxrjviAI8pc9ZiDiREoYzSX76lSoqPDg8h3iyOA7OFXnhR9tRuXK4ZmrYtd4PZcW1n0JjQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=eXIIlEO4LOJH6coDQMP4Lz0aWAPIuD9zK86P/qbxWYCaTdsVr534Szy6I7MsgWqCe4X3N3bwHwmJRnAFPNdZ2AfSbfa2xzLPP+f3yaoLLLQE/W4UBjEqSpSGwMqJoLO+E66nqnH/inQ/JZlQ9Gei0Sn46wqS+qtNikKPM8Fkc7F66rM02naqx1p444MPlogMQ7EC2D1NYhJeUjbtwUMk7kRTa0E5PZBHmZsjgM1YBtSTDvj2Bb547bZMyE5QPKsT+skkgS3h3sLTUHa8mK0UOesEzS+J/CdCl+vrQQsGmJZpx8YELnmQWxgALV0vPq7ipZPKgVGfeE3YP+agwb+MAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aFz7oE4TOZdF6wB81Ygc6ihDS1SrsLqrYDAIcsOxvR59tjPybpxrxMqw0JbBnL8aCTxVsF+tG5EOcl9CmffbB8xMQESf7OOvwAYboNGbStkvLi9Dzzy4oGfqLbGFxpv9opKwJmv/DiramgUn+Himn8frx8YZ0B71zjeVg5DwPgZV7xp9PC9zigS5wnipotlO8DHFMTV5apPcq4NBbx9rFf3PUjNXbTAPOmQWrsn/W3UC6S9+Wpn/rIzYOw0YFH5+3kXCDr8Z/+rl8aOV8MNxuwkK/3u/RgqjJHA/OLCIhrW6q46UK6Lt/IhZtWevdf9qL8xNEuIMryC8nINA35cX2Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 03 Mar 2025 09:10:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbjBo8JAfGWUcx3kan0vO/7ZnWI7NhH9yA
- Thread-topic: [PATCH 2/4] xen/arm: Check return code from fdt_finish_reservemap()
Hi Michal,
> On 3 Mar 2025, at 09:56, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> fdt_finish_reservemap() may fail (with -FDT_ERR_NOSPACE) in which case
> further DTB creation (in prepare_dtb_hwdom()) makes no sense. Fix it.
>
> Fixes: 13bb63b754e4 ("device tree,arm: supply a flat device tree to dom0")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/domain_build.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 7b47abade196..fe05cf6d855f 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2033,7 +2033,9 @@ static int __init prepare_dtb_hwdom(struct domain *d,
> struct kernel_info *kinfo)
> if ( ret < 0 )
> goto err;
>
> - fdt_finish_reservemap(kinfo->fdt);
> + ret = fdt_finish_reservemap(kinfo->fdt);
> + if ( ret )
> + goto err;
>
> ret = handle_node(d, kinfo, dt_host, default_p2mt);
> if ( ret )
> --
> 2.25.1
>
|
