[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] xen/arm: dm: Bail out if padding != 0 for XEN_DMOP_set_irq_level
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 3 Mar 2025 09:09:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SLtSEBtH/YOjom9ksXtwr6R3PBcM23fI1z037HRSkg4=; b=t6JJyT1RlL/7JZ2LgcKnUUzW1ZEjzfueWQs84Z5YZorWGMuKgyxRGMnhLI36GijA439d8EMr/lBgyZE4QLqozvhXd8OE5/+UE3pPeUp6XjDAdM/egpfyJL/L17UbVQf8Smg7J0c8W0DuX62h6EYINBvJcDKCO5OC1qA9l/PmTvFssFxUR+SYvqEPx8ldjKzlyihaqVN2XeAYB0ERR0Oent8CR+uDZyzolR9yGdh+EIIbvBGBDBHFKvQJDdjpR0FDkmhM9IclqKX/xiqJuyj8i9yM/wM5C9Fo9Tif+GpstTSIMC6OA6z/Tj4miAlnnL7saT4iRJVZORk82t5LfR38Vg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SLtSEBtH/YOjom9ksXtwr6R3PBcM23fI1z037HRSkg4=; b=Y90MZYNYym6m5g8vgRy+F79kGALlELZ98xR1bnCH8qIPGQTJX8EjiGWDkE3eoPSeM4z7w20a9X3BOh2JExf6Z1AAix5oT9ykMKEzWEaKXgJMeonWiQQVKJ4fHSOSawJlLuXKP9rTix4WxmhNlxb1tC9Inw77CgMEeYqrUyyHr00XFNhZPjsaHykI3GObynar4BTtAs+jsTMZVBUPum9T6PwjiNBobwNuKpwR8e5fdn+ldIF4FWEq+ekbYPWLrrxVEhGLUskwzS0ctLwnuBpWEsMN0LUNpju6rryXvU8EUqSBv/FV+QmMEHZE1m3Bjn6JDjTwsuhuGFW8JvAEo4l0QA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=bmMVZVnWpijYu1p0FJUSGm031vEI425i3Zlikp/q/O2O1+5cLHWzVFXMYoZjyqidkguIy7PSyDJLA2CdyzQNSpsvvvYBATB6Ot6msrmg98q6bTe7ln8IkDlkzkktXgJ6yYV9W/zdHjG0/S3aTobv5DopZiwsOx81jLB+YKaUalKMDFu8hBt4f6UTuXL84IDFFPOhLEUd/QoN9v4rMhtHQ7I7Zp2GzgW+nAQ3QwIrNLTfpqfv9NdzjOsRA3HpHnjxTavbdUwPuUuxfvK+regRUc2dRg+uGBXtMKt7F7DUSkuLS7HAoZIdz+u1IzUQrAM1e3Af73W9+KT38T3iESfOPA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GmakqQHSqGKDibiJNiYKnjAHYDPjak/Kh+JXOlcUdV7/Qk+hk4WxI8qBgIuL7/N4fw4D9OQPw3bMBrjVacWwVpK5KsJu5CYa8Wd2yHXoAAx7oO0nx0DMV1zQc2K5ZlGe8LqyPIG+1u6cVSOuNaWg93sbEuFDCKZ94LMz0Pf0ih561Jp9AFN9uxJtB7/lXRf1oHhopEZzDPsRzJPNW8l1iowoRB4J6aZNzYuqxp1Uy5eBY8duE2rfU048hd2QydsuKJV4+Tdx7PbY99Nmiy9Y2lWCd6JNjeg4WVz81WFPUHrjtXF66swBH0flqLlR259T9ptF9Jks1QbjfBS/2oTwxg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 03 Mar 2025 09:10:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbjBo7t73Clnqihk6b69GmAQ48FLNhH8gA
- Thread-topic: [PATCH 1/4] xen/arm: dm: Bail out if padding != 0 for XEN_DMOP_set_irq_level
Hi Michal,
> On 3 Mar 2025, at 09:56, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> XEN_DMOP_set_irq_level operation requires elements of pad array (being
> member of xen_dm_op_set_irq_level structure) to be 0. While handling the
> hypercall we validate this. If one of the elements is not zero, we set
> rc to -EINVAL. At this point we should stop further DM handling and bail
> out propagating the error to the caller. However, instead of goto the
> code uses break which has basically no meaningful effect. The rc value
> is never read and the code continues with the hypercall processing ending
> up (possibly) with the interrupt injection. Fix it.
>
> Fixes: 5d752df85f2c ("xen/dm: Introduce xendevicemodel_set_irq_level DM op")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c
> index 773a0a259272..fdb3d967ec98 100644
> --- a/xen/arch/arm/dm.c
> +++ b/xen/arch/arm/dm.c
> @@ -93,7 +93,7 @@ int dm_op(const struct dmop_args *op_args)
> if ( data->pad[i] )
> {
> rc = -EINVAL;
> - break;
> + goto out;
> }
> }
>
> --
> 2.25.1
>
|
