[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/pciback: Make missing GSI non-fatal


  • To: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 27 Feb 2025 09:57:45 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9LifbGEWq+1iL9mxWHvrXWvMCXOo7lbz6vsZSiJ8SeI=; b=qFcXak0FqVVL7CJ7VyUkT3aDx7HHeA4WiPbcPy18u1q9WENXDDD10HpANnIEgmgPmXM+K0b4HWhOg3XT6PQi1Zhm+pNcQ22aRqzOTMOg/ZVAhkbRcEc4mF9gNQwNEfJvo1dHvUGG8eevNCG3lFD4VQ6Yl+8xaBKB1uUMkq2QowWvRa0lpMcqeuLxLN0gUyMjFJSbKKdXtEkY4idSCG297Sd9k/p4JsoYDor1NhvhJobwg3bowTlhvWzjs1LoFnzSnfnLAIjgjh12PCVUK+uEZ4QDlSoKba2e3nZw7D/gildErFec4U9hk3Y0dWLEMrCmQk2LXE+1iBRryRGW8d8P1w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xmcAsEm7Nkzq+IAIvb8Oj++s3jdIvL28aM8h0lmvm0WQfYQ5wRIcD3lmLdzanhQMbYdKKWsmqnScMh+HWZSyFWYL0zLLva71SubZdyW8YLeUepaptshfHGl906mdD2BfYsKJR84ACqTeRgHXWsUHoE1O6mU6OyANQla+uBgkKAuFfgUhKzJeWaG1X/JUmcpyvpVp2qgj5ZNl+YCrwmZxA5/FBhlBE1/sJAueKnhYJ+2qFhY9TK0XB5/MaO5S/+9s5CF/7wPlxv059Iod6RmLnOhWlg/IPMo141ELls+v8DCFjYRWlwJbfRdg7ZzfiX9jSzcxNEiWoe0zDs0GZl8T/Q==
  • Cc: "stable@xxxxxxxxxxxxxxx" <stable@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Oleksandr Tyshchenko" <oleksandr_tyshchenko@xxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>
  • Delivery-date: Thu, 27 Feb 2025 15:09:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-02-26 22:36, Chen, Jiqian wrote:
On 2025/2/27 04:01, Jason Andryuk wrote:
@@ -475,14 +478,14 @@ static int pcistub_init_device(struct pcistub_device 
*psdev)
  #ifdef CONFIG_XEN_ACPI
        if (xen_initial_domain() && xen_pvh_domain()) {
                err = xen_acpi_get_gsi_info(dev, &gsi, &trigger, &polarity);
-               if (err) {
-                       dev_err(&dev->dev, "Fail to get gsi info!\n");
-                       goto config_release;
+               if (err && err != -ENOENT) {
+                       dev_err(&dev->dev, "Failed to get gsi info! %d\n", err);
I think here needs " goto config_release;" since it is not ENOENT error.

Yes, thank you for catching that.

Regards,
Jason





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.