[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/pciback: Make missing GSI non-fatal


  • To: "Andryuk, Jason" <Jason.Andryuk@xxxxxxx>
  • From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Date: Thu, 27 Feb 2025 03:36:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/vCG/CWAtF8MCcLgmOqylWjUjnMLN4k9a8sduJVEGU=; b=qeGVKWCdqHqnK+pWNduE1/j8JflhPkpmtqJdty3X/XtAhSGKWZLDLMtkGOxMS4/zaJ97Pnbng5BuUAbZn1MIAlLi6Cnl0+osjXpilYswHJNHyCV/MLe/Q6yypZJ7/C6Nbbz8DatOZkO8KrSkR734h+hSn/MTs39dMnTqyfso2xsAd49pw3HiLNuZQONb5pF6jWQyuUa9/hPulq9WBbtC2BzqWPzgZHlzcttANptoFl8RqT8gCJ1T5S0jOKc1jwh1wuOgLhVEGfv9+rm1uJeV4ICCzYny+O/i7Ii3Sff9dXJfngdObur29iLQcrsgyB5anTcU70kgkyUMe/AaxbB44A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NVIx4a2kwxmA8l9y+uoIrmpP4MnfaJGs1PscW85ibt1nIa1BbwGTH2dAawk5FdfixZgNyUBh6S8922jBEZjsMAMP74ppNPhtZ5tWTA2GywWAIGq/SJFba/GKA5wfTuupoflsFnbeQAc+0zX3Zb1zKaZCYqzmVjIEMbpiAO9gYw6vhuOcD5wuCDGln4ndNCiIE1l6Oj3vIfbRNeSzlhqpVl7TqSEp6dLxcrLvO9XxGb07l4TrK9HW1HrQeicCmHdNuA3OXxfrDBjNR1+e6L/M+gTEaIJr1T1hDVIijQhC2b1457VcMVP3GpdVM0seFh/E/AybRIN9yOdhSN65qtSgnw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "stable@xxxxxxxxxxxxxxx" <stable@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>
  • Delivery-date: Thu, 27 Feb 2025 03:36:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbiIkn9vQzyeCkwEWig/PgIzKlvLNbBOGA
  • Thread-topic: [PATCH] xen/pciback: Make missing GSI non-fatal

On 2025/2/27 04:01, Jason Andryuk wrote:
> A PCI may not have a legacy IRQ.  In that case, do not fail assigning
> to the pciback stub.  Instead just skip xen_pvh_setup_gsi().
> 
> This will leave psdev->gsi == -1.  In that case, when reading the value
> via IOCTL_PRIVCMD_PCIDEV_GET_GSI, return -ENOENT.  Userspace can used
> this to distinquish from other errors.
> 
> Fixes: b166b8ab4189 ("xen/pvh: Setup gsi for passthrough device")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
> ---
>  drivers/xen/acpi.c                 |  4 ++--
>  drivers/xen/xen-pciback/pci_stub.c | 17 ++++++++++-------
>  2 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/xen/acpi.c b/drivers/xen/acpi.c
> index d2ee605c5ca1..d6ab0cb3ba3f 100644
> --- a/drivers/xen/acpi.c
> +++ b/drivers/xen/acpi.c
> @@ -101,7 +101,7 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev,
>  
>       pin = dev->pin;
>       if (!pin)
> -             return -EINVAL;
> +             return -ENOENT;
>  
>       entry = acpi_pci_irq_lookup(dev, pin);
>       if (entry) {
> @@ -116,7 +116,7 @@ int xen_acpi_get_gsi_info(struct pci_dev *dev,
>               gsi = -1;
>  
>       if (gsi < 0)
> -             return -EINVAL;
> +             return -ENOENT;
>  
>       *gsi_out = gsi;
>       *trigger_out = trigger;
> diff --git a/drivers/xen/xen-pciback/pci_stub.c 
> b/drivers/xen/xen-pciback/pci_stub.c
> index b616b7768c3b..9715c2f70586 100644
> --- a/drivers/xen/xen-pciback/pci_stub.c
> +++ b/drivers/xen/xen-pciback/pci_stub.c
> @@ -240,6 +240,9 @@ static int pcistub_get_gsi_from_sbdf(unsigned int sbdf)
>       if (!psdev)
>               return -ENODEV;
>  
> +     if (psdev->gsi == -1)
> +             return -ENOENT;
> +
>       return psdev->gsi;
>  }
>  #endif
> @@ -475,14 +478,14 @@ static int pcistub_init_device(struct pcistub_device 
> *psdev)
>  #ifdef CONFIG_XEN_ACPI
>       if (xen_initial_domain() && xen_pvh_domain()) {
>               err = xen_acpi_get_gsi_info(dev, &gsi, &trigger, &polarity);
> -             if (err) {
> -                     dev_err(&dev->dev, "Fail to get gsi info!\n");
> -                     goto config_release;
> +             if (err && err != -ENOENT) {
> +                     dev_err(&dev->dev, "Failed to get gsi info! %d\n", err);
I think here needs " goto config_release;" since it is not ENOENT error.

> +             } else if (!err) {
> +                     err = xen_pvh_setup_gsi(gsi, trigger, polarity);
> +                     if (err)
> +                             goto config_release;
> +                     psdev->gsi = gsi;
>               }
> -             err = xen_pvh_setup_gsi(gsi, trigger, polarity);
> -             if (err)
> -                     goto config_release;
> -             psdev->gsi = gsi;
>       }
>  #endif
>  

-- 
Best regards,
Jiqian Chen.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.