[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config
- To: Andrei Cherechesu <andrei.cherechesu@xxxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 18 Dec 2024 15:57:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wva/7YXkcsAC6ZulTQNTl2G9Q0Iq2uJn12WHp4tfxtQ=; b=EZ4q5UqxXXPHTpM+g3H7jvnzvboJ6KCyRbfc6NBjekmA6PHpJmMOlIC7CORkEdfLn3AyN6kLXb6F6SuqvW8OX2Gk5Z4DPtyShl+TcsQ+SG/AVvlm0nqxC6no1tILShJHPKbeW9ARlf1ApaQsvJryedtN8l2+A7HFYWFiuVYnflm6fpqb8Ui8UW7NnfsU9JmTNmL6aGx8SHD1GS1a5xHNKBrT2Er4+5EpuZU9j5OS59/4Ob6znnv3T1XbATzydkppY3tifLeqcTSKYguNIPZFV0Ptb+tp/7/UynqkgBSmLAclSN9Nlwa9H0nUdRyykTA/UCYd/0WHEqL8amTqNpQwWw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wva/7YXkcsAC6ZulTQNTl2G9Q0Iq2uJn12WHp4tfxtQ=; b=PqkhtE5oR9B5Lwk9uyOrti3ZXYTd+3ToMzX1HyLuE7fKn2B/Yxjk40oTnPiRT/5tf9WS15U4wvzUu6jM1AYReNOxQAd4uCJvqKHSC6kWVntwJn//VuNppQG2kaCCvP4d+vK9MuQRl07wPiF+oK4QXMtye+Wgs7wtCFn+rPTDIARm33n7FxNVkhJHdFaXLHZptCW6L5dgl01h+3e7mi+y9tId1gZ992kw0EmteuE3oLIGrgdAYmCIvc8s6+hMoEA4wpwIwLPHqyHR1RIpA+eU4d9jEaoL0jAcvdOfZUlNQtaqRNoS8TFcFJuqr7/zzgAdhNO8VAAhIE5ZWnmh0GiiRQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=E823hqnuILMUxPsvLJvdbAPTpMI2JqN3HS2moD8zRxLPsSecm6rC91vSLCPicGANMHOEhANZSs8EXRZ4LKJfP8GTbYUPqE6ZBQiw9oF4cokzrvAYswbD7c+to0WyNXYETxPtUXH9MCNu7x4gni8IIRry4p9vaRim/iYteox398ivNGHmw2d/Ew1qw5aU6mRlJzo7w9ESjKI/NAN2TiLBl1BPa4AJyDBQMU9Esf8N3LT9kVL6RmsYNqrlMRTv1nCqFehID5OK5xMypmNZY0DNXcRyQ9OF8vXsZZ6gtLBqv5yacLof0lpq4XQM58zfqrwsSEQC1dHDCYBtfmEdr7pjjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ce09Cenn1ev86YflHNgytt+wEJ/t/+TS5D04OSEqf57WGNxQKi8J+eL9ESBGv0HjLj0MMn9Jah+cp273DU2q5TqoBJVb73kn/V3idl9PXsfDJusBzG2ZevYFJ8OXWnnzX41aRbFRqalY60SIjRK3W5NQtKASzDJhwn5afmGDuzRk20+EK5RFpRkGPVQdtzc38tK6K+Vu53WQPPq15V1+gs5fNlUK8F3ckUfQzZwYP3SwdX+oO2KnlkkeEjM1ZR2pvbHkQ2FA1j9vGqvxzFULTbsb5F9CEnJJ/xqkiiLH52Ps5WQPfYj0uRl8QLIMeMxyv5IpPVhY5hVFNzd1v0xjxw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "S32@xxxxxxx" <S32@xxxxxxx>, Andrei Cherechesu <andrei.cherechesu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Dec 2024 15:58:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbUTVdoMCMlYyvB0KhW/HQpIvTvrLsHi4AgAADtICAAAZkAIAAAF6A
- Thread-topic: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config
Hi Andrei,
> On 18 Dec 2024, at 16:56, Andrei Cherechesu <andrei.cherechesu@xxxxxxxxxxx>
> wrote:
>
> Hi Bertrand, Andrew,
>
> On 18/12/2024 17:33, Bertrand Marquis wrote:
>> Hi Andrew,
>>
>>> On 18 Dec 2024, at 16:19, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>>
>>> On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote:
>>>> diff --git a/xen/arch/arm/platforms/Kconfig
>>>> b/xen/arch/arm/platforms/Kconfig
>>>> index 02322c259c..6dbf6ec87b 100644
>>>> --- a/xen/arch/arm/platforms/Kconfig
>>>> +++ b/xen/arch/arm/platforms/Kconfig
>>>> @@ -37,6 +37,14 @@ config MPSOC
>>>> help
>>>> Enable all the required drivers for Xilinx Ultrascale+ MPSoC
>>>>
>>>> +config S32G3
>>>> + bool "NXP S32G3 Processors support"
>>>> + depends on ARM_64
>>>> + select HAS_LINFLEX
>>>> + select SCMI_SMC
>>>> + help
>>>> + Enable all the required drivers for NXP S32G3 Processors Family
>>> Minor point. Help text should be intended by 1 tab and 2 spaces. The
>>> surrounding examples are wrong.
>>>
>>> This can probably be fixed on commit if the series doesn't need a resend.
>> All entries in this file are actually wrong.
>> I did not mention it due to this fact and I thought of pushing one change to
>> fix them all
>> instead once this would have been commited.
>
> So, do you want me do address this individually in v4 (which I will send
> anyway for other reasons), or would it be preferable that you make a
> separate patch to fix them all afterwards?
Do not address this one, I will handle it with an independent patch after the
release.
Cheers
Bertrand
>
>>
>> Cheers
>> Bertrand
>>
>>> ~Andrew
>
> Regards,
> Andrei Cherechesu
|
