[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] xen/arm: platforms: Add NXP S32G3 Processors config
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Andrei Cherechesu <andrei.cherechesu@xxxxxxxxxxx>
- Date: Wed, 18 Dec 2024 17:56:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4JyZOShfVQAJqhnlrx0QGPcJpdSXxYIrA6vIR1iKnVs=; b=taAzQ54OAQL60ywrF8T/bKIPaNMFklh6oWwEGtWmYGg58cJ6zXwcYQH1Tv86jTAyMpUPFpO9CD+ReIFPQZVr1+qZys8mhh1SGWTzEWG8U99W9JLP1ovsvASLAmwH7hRsd8JNlQCdCJ96N1HtxifkHw1VuYcP0rURgHQ87lzrz1SU6vHydRVJS5IarP0v3/iftX1mVxd06K3WUK/JuMlwrWUKjPtOuYPhD2ddvCeQ5YNxfl4fpxIxsrC0brToZfY/4XK95VpWqrlC2sVP4sJ+YzfOirqeXxNlhNgJMkbKlZerVbRRgaiCmfjOzECXGv7S3whgpYY1EdmQnYn4Qqkb3A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F7esPi9PMGUtfiQVDYZ8N8MQdRMZsRYTzCBNTO6BrwTf9evVMRf6Z4JnxC51jGCVDDNIGaH2iEQThWhq2/OCDsrgsIiz74XVagTh7tFkjqx8rnLiG8Zj7lXumYRpfBz+OKNkHh8DazSJNuVUXwZE0+2FZzCQOE44FzyjMUFYE+Bx52y8tc5R4J9qrKSXrfZHH/DA2FPKW7CRRiKhFmsvL38lvclP2EQqVw+iX7gG8BKywPlakSkyPuhyMBnBnChZETlJfxE6kabJMCw9aYSMutSavSQsJY9qKHqpe6ZMKrHEhzKFmWz+qFpGdBN0ttH6AYCn83VteKZH/pCEeGqkwQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "S32@xxxxxxx" <S32@xxxxxxx>, Andrei Cherechesu <andrei.cherechesu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Dec 2024 15:56:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Bertrand, Andrew,
On 18/12/2024 17:33, Bertrand Marquis wrote:
> Hi Andrew,
>
>> On 18 Dec 2024, at 16:19, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>
>> On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote:
>>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
>>> index 02322c259c..6dbf6ec87b 100644
>>> --- a/xen/arch/arm/platforms/Kconfig
>>> +++ b/xen/arch/arm/platforms/Kconfig
>>> @@ -37,6 +37,14 @@ config MPSOC
>>> help
>>> Enable all the required drivers for Xilinx Ultrascale+ MPSoC
>>>
>>> +config S32G3
>>> + bool "NXP S32G3 Processors support"
>>> + depends on ARM_64
>>> + select HAS_LINFLEX
>>> + select SCMI_SMC
>>> + help
>>> + Enable all the required drivers for NXP S32G3 Processors Family
>> Minor point. Help text should be intended by 1 tab and 2 spaces. The
>> surrounding examples are wrong.
>>
>> This can probably be fixed on commit if the series doesn't need a resend.
> All entries in this file are actually wrong.
> I did not mention it due to this fact and I thought of pushing one change to
> fix them all
> instead once this would have been commited.
So, do you want me do address this individually in v4 (which I will send
anyway for other reasons), or would it be preferable that you make a
separate patch to fix them all afterwards?
>
> Cheers
> Bertrand
>
>> ~Andrew
Regards,
Andrei Cherechesu
|
