[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v10 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Tue, 25 Jun 2024 07:46:02 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M/s2phCOFsIJhg/V8D4l+vBuLM71RAMOKB881PNaBLI=; b=FnIEWEAyAsf2alCafGV4EeI5UaajLiXtN7lAO8/6IdDTuc/u1Pp81WZqiFe7OjF613WLZg/BdvqBCaOMX0+nJuau7Mg4flzvsgYsghhPg2sDHvh1fhJWHUs93hMD6Qgt/KccoNnAPGEQnIxNMFvHuLhZcw2uMgxLO+a0rXfDlQ4P+/Y9OuHdBvKJfhfArtc1m7vUoAL1NiLZJiGYnXyvlIRITHqglPHssj4esFYJH4N4HYmaWvUPPRX337O11I5WMavWwKydkauqaEUmTY2liRwwMNNFnw2hpmX3ZOr43fPBLw4qu7ktrIaz93WZnkPqARUAvriOIOpifpT6Ey97Nw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMDj7TH5z8mc3opBJA0OkH0lAPWGthhf62ttW7k4kmHiUrJJDFE50xCkmBF9qsnnyl2JzPTOzablr92bkhB9DKFkMIrT4XrJtgmVbq3Nq1j72BL2ZdOjr4OvodL8ZcYK02ptKXSZmCGpb8F6PSfdz6tWw4EXJV6WaL/FShvIljsL2VcF9G2QZVGHWW+CIc7ZpSWEzTRMrznswlVNxHVILM4AFT5Tto/BlXD3CDKoYBhwZLy1XiW+lnLrG86cUDD3iRZXCSBHj0OSuB1kX5fCC9Z0HVtbqkOb6wmbEWIEF2+eduWBHKomrBPhcl3iYwIZvIqnKWkYudhpourxwOlRMg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Tue, 25 Jun 2024 07:46:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHawJTqXyg3PMEiVUiLHPQ86aZkYrHMFeyAgAGdTwD//43bAIADi4UA//+vaICAAe+IgIAEeJ2AgAHGqwA=
- Thread-topic: [XEN PATCH v10 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi
On 2024/6/24 20:33, Anthony PERARD wrote:
> On Fri, Jun 21, 2024 at 08:20:55AM +0000, Chen, Jiqian wrote:
>> On 2024/6/20 18:42, Jan Beulich wrote:
>>> On 20.06.2024 11:40, Chen, Jiqian wrote:
>>>> On 2024/6/18 17:23, Jan Beulich wrote:
>>>>> On 18.06.2024 10:23, Chen, Jiqian wrote:
>>>>>> On 2024/6/17 23:32, Jan Beulich wrote:
>>>>>>> On 17.06.2024 11:00, Jiqian Chen wrote:
>>>>>>>> @@ -1516,14 +1519,39 @@ static void pci_add_dm_done(libxl__egc *egc,
>>>>>>>> rc = ERROR_FAIL;
>>>>>>>> goto out;
>>>>>>>> }
>>>>>>>> - r = xc_domain_irq_permission(ctx->xch, domid, irq, 1);
>>>>>>>> +#ifdef CONFIG_X86
>>>>>>>> + /* If dom0 doesn't have PIRQs, need to use
>>>>>>>> xc_domain_gsi_permission */
>>>>>>>> + r = xc_domain_getinfo_single(ctx->xch, 0, &info);
>>>>>>>
>>>>>>> Hard-coded 0 is imposing limitations. Ideally you would use DOMID_SELF,
>>>>>>> but
>>>>>>> I didn't check if that can be used with the underlying hypercall(s).
>>>>>>> Otherwise
>>>> From the commit 10ef7a91b5a8cb8c58903c60e2dd16ed490b3bcf, DOMID_SELF is
>>>> not allowed for XEN_DOMCTL_getdomaininfo.
>>>> And now XEN_DOMCTL_getdomaininfo gets domain through rcu_lock_domain_by_id.
>>>>
>>>>>>> you want to pass the actual domid of the local domain here.
>>>> What is the local domain here?
>>>
>>> The domain your code is running in.
>>>
>>>> What is method for me to get its domid?
>>>
>>> I hope there's an available function in one of the libraries to do that.
>> I didn't find relate function.
>> Hi Anthony, do you know?
>
> Yes, I managed to find:
> LIBXL_TOOLSTACK_DOMID
> That's the value you can use instead of "0" do designate dom0.
> (That was harder than necessary to find.)
Thank you very much! I will use LIBXL_TOOLSTACK_DOMID in next version.
>
> Cheers,
>
--
Best regards,
Jiqian Chen.
|
