| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 Re: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module
 
To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>From: Luca Fancellu <Luca.Fancellu@xxxxxxx>Date: Mon, 13 Nov 2023 14:32:37 +0000Accept-language: en-GB, en-USArc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=noneArc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMjEqzAg1EVqIbFSpF8TUfhLyUPn2l0YoDvu5OikYYE=; b=AoAOZ+D0pjNA8yERXv8w3xD+QMI3V4NosxjEw3EZYFu5O56GcDYmB0wp8zHVXpy8alYWO7HXpgn2lRLnK6wZpIjjDI55irthiPJPYbzyMmv6KW1D+ABdF1MwkPnCB7WL7Zfe0gnoabxZYbQS7i0xhOPlhrZLSYaFfUoSUCjPVoQwd3LsycTaf6iOPrNTJ+BFjbbWlRW3Kq4BaRni89B6BnS7hyjud/6nYLqYnI+znnnnJ2UYvuRRRA7mBE0p92xiHd2ux4jixDHmW34v4KpCLVkL93BVvX/IGDEBDnZhAP8iyMZ7Mh0PvxFlsvQHwRilKFiHews6bUFfQfrUr3K6jw==Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMjEqzAg1EVqIbFSpF8TUfhLyUPn2l0YoDvu5OikYYE=; b=GKIGwe59w/4B4ZnpnMCp6hjIAA1mIx61mAhIWyTMnpCf3D4OoxCErkbZNPrhGRgaPxBkx7U1XLtwThuJg9WFVGKWPXGpIEAc/2KMYnhZDFO9MK/Mb75mQWMJBkNipKVxz3khPONDrXU8yHC5TBkidbnEh3qigCLuMjJvZDgs0w7rKqcsRudZgk/X4itHALWeWXFWK90zohaEPoQ6Az6bCKFsg3CCBM9wjHXuUg35Wys51lXy0x1mTLYXKJf4XDl4pAiVyoX2ioYMLSg9Wpd0fpEVOte4DDzqXV2kgYrAatHOL2r6bGy675gzrZ5cVQdAVhT1eXPvCdcVhcGzaBl3Jg==Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PNdyv8po6yKpQNZJ+KRVHtiRmKZeiS4AQmIpsm3Pz5DrR0JodrAadlj1xsvOgl46YAfM4MwKIOm9BOLsTlMUg+IR7oWg0YkqTIgoELNpYOGqJInrxSxkEk/jYuRK+hrnQQV/HPKUZ+wUUUJJNfxP0CdfNPeSNiSJ7qFPumZ0VkrVeMzd+ENjVoA/FL/cS3uhm7uJ+mGR3bAJACFm/ZV0VTWKHQOjlPWQf1qnlzj9xV+C3WRzV9DOjhDfwhu7U232OW0cOr61YBVp214jvDigrWaE79Ipc99rtYAwqFK4QpnTuzuDTOVvtgvozUZiWpi45Pa0qVlTwz+oohrJhQfXHw==Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MdB+54ODJoX9v5S3FNIrlqIUqMUzhzNzeZjvcLg5MQGKXvBz2a6aQsm25pZxEWu/Lyoyp1HRqC3YRRCEM9uGtfuK7UQ02MI9mc85GL9sVX572NWbFCEYvejhFo/RMvucceqBiILKBvmCTb/5f96hfC1ulaLifB829nPOT1VpS1bygfZuv1TqfmOpbvXKIQC7GRHexEKNHSQN/jTvDVQS8M+5h2oqA+KiBTvQH803TsvgclQZNoxK/Ru15tlRIh3gCgnTvH2SBmuupKVswPv4aKrPAcX3qaGVttYoevk2UmaASlaCdT179Ba8N2v/Vr9HsTCiUMcP41PyQm9rIVkUjQ==Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;Cc: Michal Orzel <michal.orzel@xxxxxxx>, Xen-devel	<xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini	<sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk	<Volodymyr_Babchuk@xxxxxxxx>Delivery-date: Mon, 13 Nov 2023 14:33:08 +0000List-id: Xen developer discussion <xen-devel.lists.xenproject.org>Nodisclaimer: trueOriginal-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;Thread-index: AQHaEuwcMi2uzYg9sUaekJ4uQMuKYLBx1QmAgAY1GYCAAB47gIAALj2AThread-topic: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module 
 
>>> I can see you removed the copyright from .c but .h still has it. This also
>>> applies to other newly introduced files that were subject only to code 
>>> movement.
>> 
>> I’ve just read again your comment, I pushed the v4 but removing the header 
>> only from
>> dom0less-build.h.
>> I left the header in the other static-* because that I think was code 
>> produced by Arm,
>> please let me know your thoughts about that (you and the Arm maintainers)
> 
> Even if true, adding the copyright after is a bit odd.
> I do not think this is code on which the copyright really has impact so I 
> would not add it during the move.
Sure, I’ll drop it 
 
 |