[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 13 Nov 2023 11:46:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTWaOxE6dzqJtw23kAT2/4a6cdqCdv9JRCYfJ8OKIxE=; b=iT2c62dcZrgc1zw4zuLUjw9xMDLjLrD7R33QXZg5HQY5vIOFGsLy1ZTLyOd0Hs/avE+5+OVEjh0JS8NitOjse2YuNRXecCK5jlGxekxxBidTQ3N2qzMY6YNkV5yps4Ye2lcXCiGb6Tixcv8wibMThx0H5G7kaM0fYR5VzRAf+ecA2GnufTK8i+h4JlngomPcit8pjXiHaqxwV4R3l439tWet6xBRPlVQin1ejfB8n7FYrlUTwhXM3s65pmgJVEazROwiSj6pvJB7yPuH1tViol9uvN8+9LK6qrbbp4YFG6Y+ROaxy+wR0GMKLxnaNZaAFV7y/N6mNkz1vC5E7OT8Hg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTWaOxE6dzqJtw23kAT2/4a6cdqCdv9JRCYfJ8OKIxE=; b=Zmo7+DHiUSUS+/rh8nHdZMDS0+USasi3PHHU6PQ+R/Q5WKTqb7tXnM7mIhKOfbIqAbuSkfrAXh59x30wPd+vU44TfnlguUBd07Org+QHLiMKONRJBHJqh76EwisOh8f0iByuA2MGv3qQEeIWAnGBzscjbua4SWG9MfroSwmPHbcQOS5bo7GCK7HkLxIVTPiJYN+WyZSExjREeYxPNFhpakw2lyzISWvn8H5XZgiGGNWsVsD8nQEcI5hKQn0fj5bQ6kiIIOvHoqkf5h3ywWdCiO2jGyBdRyvi4yHH/C2Y2sv9LEavzu+YjlPXVxPWv7y22UDuU4nBoURPHMwAY0jE/A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AFNn3NUr36auTWBsie4V1sSA4HHGfemdZsGtKf1droWm7QZBHFyvf+uC5SWlYQxK8JLNTbbzogtwhaL26BlyUW2jMYQcO9r9g1HqWJpyTSo+ofmjtbrNB+1MfVrv+1mr2eXm3fzVpu/vk8ILTQQXW2SmVtbTUmJ7ZdBUFkw+wentdeD8lxrZ/M0mq4Aa/9zz2lBgG9c3VkT0YpeHfWQeDcd2IB3qveBHdxL7SHh/ThkVUJznDAfsvSUH/nCwYGo5zSnVd5Nm2OznxnAoxjtdbxFN+UgHNvtbhbWA7FugilFjpySinVSMwjUCIAzWPHOpMKME17qP7oaqKqDuO1FMhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSpkjYtiaGkOS7ufGrThtNUi6hWZoLuEZh9s8HZfjMa3pihdjjsI9gQE2Cc+8d7T3yJJ/ql1MDqEnfTr4/uZju6IO0pSI7j1IWy+Yzpi/LZTQrz4xOeiC288vvg5tsh8mQrCGkT7hQ1azN+g/RrsTN/XhlLC1TtsBqxfYrZCLV1lVoivvLas/REuOabnyEQ07AKPoL84U2AnD/1WSloPlD46yTVy+4dLWbgvFboDOeQqFP3leEmLfy1i84cp0CdcId1A/gEt329N5/EQ4maEFis7N6tSfPCZyHePaoloWL2fHOo0Sv18LstSnI+6YeYgZ37SSgcDbYs0g+5ZtGZzYQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 13 Nov 2023 11:47:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEuwOi1mHiP9SFkaZdsiI0By9x7Bx1QmAgAY1JYCAAB4iAA==
- Thread-topic: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module
Hi Luca,
> On 13 Nov 2023, at 10:58, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>
>>
>>>
>>> The functions allocate_static_memory and assign_static_memory_11
>>> are now externally visible, so put their declarations into
>>> domain_build.h and move the #else and stub definition in the header
>>> as well.
>>>
>>> Move is_dom0less_mode from setup.c to dom0less-build.c and make it
>>> externally visible.
>>>
>>> The function allocate_bank_memory is used only by dom0less code
>>> at the moment, but it's been decided to leave it in domain_build.c
>>> in case that in the future the dom0 code can use it.
>>>
>>> Where spotted, fix code style issues.
>>>
>>> No functional change is intended.
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>> ---
>>> Changes from v2:
>>> - move allocate_bank_memory back in domain_build.c, remove header
>>> from dom0less-build.c.
>> I can see you removed the copyright from .c but .h still has it. This also
>> applies to other newly introduced files that were subject only to code
>> movement.
>
> I’ve just read again your comment, I pushed the v4 but removing the header
> only from
> dom0less-build.h.
> I left the header in the other static-* because that I think was code
> produced by Arm,
> please let me know your thoughts about that (you and the Arm maintainers)
Even if true, adding the copyright after is a bit odd.
I do not think this is code on which the copyright really has impact so I would
not add it during the move.
Cheers
Bertrand
>
> Cheers,
> Luca
>
|
