[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 13 Nov 2023 09:58:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tgs8imh2O3/Qs4hf4jV1+sMvl95XSbIL9e+23/wUkfM=; b=VrVrdGTf2rZI6wsOpFeB8fR1wX0my5W0BD28YKjs3RwyZU4Ez0GF3XdZjda91FDV5JV+oke429X6bbsB9C/gdF+zuAbYnd0H7EMjQmkGiBnyKhycV+UGnocmgOnJV2VEnuuBEcRJ49zJDJdo4t7BpvKEE6hmJCmG/Sr55wg0KtdC8/So29mOiEdiWZOJy+/m54+nZYvzsVKL2uSsVsLOLh2hIntHmtQ0GO+K7dwI0KQHG9Wsh3ecMkAMJKwSv3gIl3bG2guP6ytePqjzZs/OeTWL2xDo/pzfC+W7bMN4ZZx/NEW38e4js3ol91x2nu1e+dCwYO910kBUUpZk6jKCpw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tgs8imh2O3/Qs4hf4jV1+sMvl95XSbIL9e+23/wUkfM=; b=EzVPA+xSp1UpRwNouiW6lvdTjxkcaRFIp2bYKZ6UPiYR5I60cgauZAw7hksSGNwH+F/e8gw/yC6bzwRvMfmEQ/wV/GoQbUO+jc3Qnaw8LOTpR/oL07G9HgZOOMqz2uBt9kxCH5jLrlJ1Y84i/C/55WpowqJVnvUnuNa1zWoPjrenL2Gas4nOLIfv/3WZINebXFXjxrDxBABPO/sttCJpSGw+4qEMPuKn211gPaTnYcx+wU71GhfRIyGG3sc2DhA3bSxllIpF74YhJW+7OVoOBpbNL+6G1j+YMExv6SwSUj0JPYCljAhE1JCR82c+PowYEMfQu5w8gE1+ALwTFw5aHw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hxCykQ50O6QPzcWcVLel4FrjBWCqueO6AltykVJGZvoVixjTCgEXoXB7XtcgALNnKNFniigmbxC6PDgFsum1Ytjd3q9amtfwfAgZGhbHWWdC0osI7shPqO5Hv/boQ21v1BDi86ges4iiF9Z9mwGqe+YoYiSmuEWaYE1UUByghMnCh+SkzUBr6gEvQ2wZHClWJkI0a+EK1bSv/OppxhMfu6kXHBFWgDuy7j6tAuomdhVuYCUDoJuSBK2qwx0wMo/ynu7M+rZPYHU5z6LUVxhftkKMj2eSoBuu8lJAJN9ErnMoszIduy0Crum1Yf3iUEIrjXO0C2/xBiMcMFrZpHhLYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kle6iVIbBdCoLq+ozJ2zd0swoGr+cpQGP+m/ispU+TdasVwRDOOjQhsMfIpe178axK9zIpjwyKswU8gz3/2MQYDO09BupmexFZHTip6GeqPGek0oDD7szb5hyb+D8Wxqn4JlZlD5PUS+17v1ot2Z18rlq/UJ7WJZjoYNv756iKhDwEyvJU5C6iX+hE/5T3p+AK6Can9AnfZ5OCHof96f9xf7n5qP5XwwsMJvwgXc0/i9jLGeFKhvrCId80mW+tscJI/qIrkZzqiiHQN0w3G2astwDkvhGHeLQm8yP0AwEcxN5dmoSqiCUCvJNebxflQuf+S5RrmBor70s2Eh64SgYw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 13 Nov 2023 09:59:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEuwcMi2uzYg9sUaekJ4uQMuKYLBx1QmAgAY1GYA=
- Thread-topic: [PATCH v3 3/5] arm/dom0less: put dom0less feature code in a separate module
>
>>
>> The functions allocate_static_memory and assign_static_memory_11
>> are now externally visible, so put their declarations into
>> domain_build.h and move the #else and stub definition in the header
>> as well.
>>
>> Move is_dom0less_mode from setup.c to dom0less-build.c and make it
>> externally visible.
>>
>> The function allocate_bank_memory is used only by dom0less code
>> at the moment, but it's been decided to leave it in domain_build.c
>> in case that in the future the dom0 code can use it.
>>
>> Where spotted, fix code style issues.
>>
>> No functional change is intended.
>>
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> Changes from v2:
>> - move allocate_bank_memory back in domain_build.c, remove header
>> from dom0less-build.c.
> I can see you removed the copyright from .c but .h still has it. This also
> applies to other newly introduced files that were subject only to code
> movement.
I’ve just read again your comment, I pushed the v4 but removing the header only
from
dom0less-build.h.
I left the header in the other static-* because that I think was code produced
by Arm,
please let me know your thoughts about that (you and the Arm maintainers)
Cheers,
Luca
|
