[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/29] xen/asm-generic: introduce stub header paging.h
- To: Julien Grall <julien@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 12:49:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OVjbXoRLzrAgp/ihPPVwM/kGZFysrF9AM61GmSMhvxg=; b=muhpA/TQnuUjyB626AiUwOZ+BiyVa6+7KVm+D73MVJhzZFDf+XEb/yMwDow3Y9tvlegJKq226w8akj3gAHb/fXeI93YJaIlHZoitknkBMYS8WCZejpEtYgb6cQlZz3F/hTkm+uUM4rfT/judwWkfHWSr8AYg4B8fCfIYN4zPR9JgPug9+7dmMAwc1u9wPpRuBVwZvd+LcwYbDGve3Q6HvqKzJEkWhWlAhugqJYir499sAF1NgDJ0ZcTGl/pQLtAnUkFGqlfQo1r1oVSTEhgXua6+bFefyigVJMKcPUYAmnjLB31A/+xNdfZtL7zsQi+Wng0tx803gxRrA/jMn6X02w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DYRWh9AlyOEZCPh88+1XwXuAMmvR7TEy+5J9j+Ij4TZ+pa9ejIwUO5knc5gRHqx4KtqFLZoIr0hJtw0qZnt4x+59v6o4HBAD/ZHeqXS5nb0fQfG0Z9qjIT2YO+nJdrQ86baYIO3/kmD34E2PKN4c0zPx6D67TI+8wq/l5eq3gUine8qB1TKKOZsxVw2qjLMTxulNruZeA48JiyevlvALzihj2HrBoxccX5zjSiislfbPpoLbvt1chq9Y8CKXgZlnDcVftoE1EGpx4/MXEon0xpqhE4444h6p94aZy5zwV7bllctXvxdBx8duVm/PtfkijISio/ABvxUTIJJSDIGRFA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Oct 2023 10:49:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2023 12:35, Julien Grall wrote:
> Hi,
>
> On 19/10/2023 10:05, Jan Beulich wrote:
>> On 14.09.2023 16:56, Oleksii Kurochko wrote:
>>> The patch introduces stub header needed for full Xen build.
>>>
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>> ---
>>> xen/include/asm-generic/paging.h | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>> create mode 100644 xen/include/asm-generic/paging.h
>>>
>>> diff --git a/xen/include/asm-generic/paging.h
>>> b/xen/include/asm-generic/paging.h
>>> new file mode 100644
>>> index 0000000000..2aab63b536
>>> --- /dev/null
>>> +++ b/xen/include/asm-generic/paging.h
>>> @@ -0,0 +1,17 @@
>>> +/* SPDX-License-Identifier: GPL-2.0-only */
>>> +#ifndef __ASM_GENERIC_PAGING_H__
>>> +#define __ASM_GENERIC_PAGING_H__
>>> +
>>> +#define paging_mode_translate(d) (1)
>>> +#define paging_mode_external(d) (1)
> This is more a question for Jan, in the past I recall you asked the
> macor to evaluate the argument. Shouldn't we do the same here?
Would certainly be desirable, and iirc actually needed for one of the
Misra rules.
> Also, I think we want to take the opportunity to convert to true.
> Lastly, this seems to be using hard tab rather than soft tab. In Xen we
> use the latter (unless this is a file imported from Linux).
Oh, didn't even notice those; thanks for spotting. If we're at cosmetics,
the parentheses also aren't needed here in the expansions of the macros.
Jan
|
