[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 10/10] arm/smmu: address violation of MISRA C:2012 Rule 8.2
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 16 Oct 2023 13:31:16 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1yAZN0TUi50zVdoWm0Ve0fhs//+isYRRcT/AXWAbQ5I=; b=YvZDjYBoXuec4M4udwpQ26pG2fwCy9toj7snXRdtjxN3CDXLxSlUCJPDjlUThkUXVebFANX5RGCT4M1F3HCjY0d8HniBbuCchEt5I70N2TUzUBv7u23jf2gJO76by6DxGbvbKkYYWOTWfBKvOSGU8Oz9lh2motMvJbXIqPRd3Mg0p6/EC2Hn/xXJlZk3BVJYNTu/Ay9dr+oPnBEaOJ9vaQqtLPvkZCjYV/bZLBOtw31RLdfFxQDB+Tlg8ccAm8q5OwjAsCuuycFDWWAcd8j9p9YOSiADe71D8Z+yLq2F34z7nuVAF+BRXZJSAxVT7KnZ0x+UUUIhAlqabt4B6f/9ew==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+HSms1fLr/K3bxL3zz4abPjDRUe82BFAallmG+oFP4kYRBUz6HHphEs1uPDgxrFGeoK/Nb0qUPrjamos0nEQcKQJM4nOdFZlNm+m64g9k/uuE+vPmdoPx6tRTwuHSPdP1TviWctCZ2enkwso3GT7SpEut9pJ5zl+jTcWzAIEUFE8MuLhZONcvHdK6j8XLF8bqz+Ry7OjXBy+hdXA2qXOB9G1clXVNXmxDZ8Y+kHPDKBzoZ2BLddKAXW6owe1gcgtrr87PvEkBFvfB2BOfBs51bQQA7JPOBJBd17hYx80o8GunLp1/e9wH8g9P/8U3S8KjpnpVfSZ3FOEZUaZNBIQg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 16 Oct 2023 13:31:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ/el7rXFHK+9WvkOYQpiDC7n8ALBMJIIAgABJsYA=
- Thread-topic: [XEN PATCH 10/10] arm/smmu: address violation of MISRA C:2012 Rule 8.2
Hi Julien,
> On 16 Oct 2023, at 11:07, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi,
>
> On 13/10/2023 16:24, Federico Serafini wrote:
>> Add missing parameter names, no functional change.
>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>> ---
>> xen/drivers/passthrough/arm/smmu.c | 6 +++---
>
> This file is using the Linux coding style because it is imported from Linux.
> I was under the impression we would exclude such file for now.
>
> Looking at exclude-list.json, it doesn't seem to be present. I think this
> patch should be replaced with adding a line in execlude-list.json.
I think that during one of the discussions we said that this file already
deviated quite a lot from the status in Linux and we wanted to turn it to Xen
coding style in the future hence it is not listed in the exclude file.
At the end having a working smmu might be critical in a safety context so it
will make sense to also check this part of xen.
@Rahul: do you agree ?
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
