[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [for-4.18][PATCH 0/2] Fix AMD erratum #1485 on AMD Zen4
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 13 Oct 2023 00:29:20 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KarQf0W/wbuxJNCMhPrfn01FFwf19dtbWiRrong4gNo=; b=TFczOy7VJZkBo/VeEq5LK5rc3X3mTKkVucofvhLXOstRWKv1bCmqbHhVxzxdJOLqsyTX0vMCA6OtfUtq94PVoQqoJtmk3Hs7NU5b9CfirWJQMMvw7d6tn8/ZOuU0TUKw8d9uNS5FkxdCNgCGRWIXpE05qmNEve/4o6ep8uvK25mLFiAkJK10XMx4CI2IXVOPlSvmg5fVBeHKrupADmj7JTgdzrxhLG8ZSPUSCbCA68D07Y1pMI2MASsqHNOLTUEgIlOopK/Xq6KHjSnTHNma/k9K7gXAnQdppeT36Mr+XQU+r57Dw57zkhvTlgDgg+59oY5ZWEpxvXkeRaPfUJitVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjGXm/dzFiAPZjVQ0/DiIac9kb2XfvrcCpfYBSI7yGELiR6uYAJ1yU1RpIfdk03HElY2eNm3oMXVqdpLxoiv0jpwNX4xgpTm3+j8hIs54zpWtGyqQ1QnixP9xyXWlJp08MkHeb0wIke0k/wwKeG/hjG6IHGTzZZ0utiAtQWoajyD7ZxNSZlbEkNJiZ4X0waXZujFWu7rUrYh3Q3BLJmb93JTBdw0zoFBaUxs65NoBwBsrGn91cRo9ytapH1cwWXZ2QHUSj0noS9B2//7D5b/jXop2KVxpOoVZhYdpjm4KeKq4CtJ8gpHJQnv6lykmBIV8WibushvwX7ah+SeyXjIyA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 13 Oct 2023 00:30:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ/TE50gYu+NMZvE+XlASHnJQ+e7BG3i2A
- Thread-topic: [for-4.18][PATCH 0/2] Fix AMD erratum #1485 on AMD Zen4
Hi Alejandro,
> On Oct 13, 2023, at 01:25, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> wrote:
>
> This patch should make it to 4.18, as it prevents random crashes on AMD
> Zen4 running outdated microcode.
Yes I agree, so for this series:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Under certain conditions Zen4 may corrupt its own code stream when SMT is
> enabled and STIBP is not. The Linux thread in which this was highlighted is
> in patch2's commit message.
>
> NOTE: Still running in CI as of now, but tested locally. Pipeline here.
> https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1034895039
>
> Patch 1: is just a minor refactor to ensure we don't get microarchitectures
> of different families mixed up now that we have 3 different
> families involved (Fam17h, Fam18h and Fam19h)
> Patch 2: The actual fix. It involves setting a bit in an MSR if it's a non
> virtualized zen4. It's not a direct copy of the Linux patch, as we
> have started using macros to find out microarchitectures from
> CPUID bits, rather than relying on models.
>
> Alejandro Vallejo (2):
> xen/x86: Add family guards to the is_zen[12]_uarch() macros
> x86/amd: Prevent potentially fetching wrong instruction bytes on Zen4
>
> xen/arch/x86/cpu/amd.c | 16 +++++++++++++---
> xen/arch/x86/include/asm/amd.h | 17 +++++++++++++----
> xen/arch/x86/include/asm/msr-index.h | 2 ++
> xen/arch/x86/spec_ctrl.c | 3 ---
> 4 files changed, 28 insertions(+), 10 deletions(-)
>
> --
> 2.34.1
>
|
