|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [XEN PATCH][for-next v2 6/8] x86/mce: Move MC_NCLASSES into the enum mctelem_class
The definition of MC_NCLASSES contained a violation of MISRA C:2012
Rule 10.1, therefore by moving it as an enumeration constant resolves the
violation and makes it more resilient to possible additions to that enum.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
Note that the use of an enum constant as operand to [ ] and != is allowed
by the Rule.
---
xen/arch/x86/cpu/mcheck/mctelem.c | 2 --
xen/arch/x86/cpu/mcheck/mctelem.h | 5 +++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c
b/xen/arch/x86/cpu/mcheck/mctelem.c
index 329ac20faf96..77a4d1d5ff48 100644
--- a/xen/arch/x86/cpu/mcheck/mctelem.c
+++ b/xen/arch/x86/cpu/mcheck/mctelem.c
@@ -64,8 +64,6 @@ struct mctelem_ent {
#define MC_NENT (MC_URGENT_NENT + MC_NONURGENT_NENT)
-#define MC_NCLASSES (MC_NONURGENT + 1)
-
#define COOKIE2MCTE(c) ((struct mctelem_ent *)(c))
#define MCTE2COOKIE(tep) ((mctelem_cookie_t)(tep))
diff --git a/xen/arch/x86/cpu/mcheck/mctelem.h
b/xen/arch/x86/cpu/mcheck/mctelem.h
index d4eba53ae0e5..21b251847bc0 100644
--- a/xen/arch/x86/cpu/mcheck/mctelem.h
+++ b/xen/arch/x86/cpu/mcheck/mctelem.h
@@ -55,8 +55,9 @@
typedef struct mctelem_cookie *mctelem_cookie_t;
typedef enum mctelem_class {
- MC_URGENT,
- MC_NONURGENT
+ MC_URGENT,
+ MC_NONURGENT,
+ MC_NCLASSES
} mctelem_class_t;
extern void mctelem_init(unsigned int);
--
2.34.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |