[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Aug 2023 16:06:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FhUA5NsuWDlnopf/bqdUYEngu35mooPiQlSbCKPaHSQ=; b=AKGlm6msXo/CLA0RImfUQsj0xRCLr/dEGTBhUzW9Bo2Wnet3D8n6JNNlEt7pjOGqVZN3ho+45v4WqkMlg1kuKY7dCIfA2Er4DsS98cbgXYISw7r3217cjr6gIGJS5RwgEVCxSApasGZhAo9EjRsYUn8RNcHDYnXgNb82Uk/+Qf+oIkNgxaO6G5Tkulw14AHcEowYcoCUMIaWHIAsBeT1guF1fNZOeWQSeS30gD6X9Pw9YJENBDJ6SMJTPv7x7PnHlrJQ33pCFWIpD+w8VHT1b+3aG6uCYAer7X1j86ffoKOoLUUn0lfBMM1v/dvZZ6R0I6QujJ9V0PJrmtvlE3ITxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKEfx+RThUtbNvHdDgsfKz/HFWDbQo41PQPxMoFy61JlVcQ7/O5qc1Mn5m9k6Up2ME64QFI20a8gbOEgG8bUM6QgaFurWJD1MUTEJr9W9Bzy1YcrJyVjQwXTUDNLn6haAk8mce9y5XpmIfBxASlBoy2Ui5MXGUVyeELcJDjfjAAFq9p7xsU52P/Ld02eRFkcykYPVgFSGCK0F+Q7phDOCEq70Io0sBkWYYpOGgxWNxtnxm3pGtlpkpdpHd7ZUp1GFz/FJpa+8vq20JVmNFWwzZK/Cvz+mx2PyOF0JWbMMecN/Uouvh6VxtFX33EUThg7EPREyXFaTrqpciW0kpGPyQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Delivery-date: Wed, 09 Aug 2023 14:06:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 15:50, Luca Fancellu wrote:
>> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>>
>> The variable 'saved_cmdline' can be defined static,
>> as its only uses are within the same file. This in turn avoids
>> violating Rule 8.4 because no declaration is present.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> ---
>> xen/common/kernel.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/common/kernel.c b/xen/common/kernel.c
>> index fb919f3d9c..52aa287627 100644
>> --- a/xen/common/kernel.c
>> +++ b/xen/common/kernel.c
>> @@ -28,7 +28,7 @@ CHECK_feature_info;
>>
>> enum system_state system_state = SYS_STATE_early_boot;
>>
>> -xen_commandline_t saved_cmdline;
>> +static xen_commandline_t saved_cmdline;
>
> I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397,
> have you checked that making it static was not affecting anything else?
The code requiring the symbol to be non-static went away in e6ee01ad24b6
("xen/version: Drop compat/kernel.c"). That's where the symbol would have
wanted to become static. But that was very easy to overlook.
Jan
|
