[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3.
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 9 Aug 2023 13:56:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AHdWBxCSqPq2YeMQiK1OXXbKH02/DFQllBT60BSrEtA=; b=UEU7TS3bASADIbhBvzkCXRTQhYx/Wc7XfC19i+NFYMCaqLGSEZ0sPWTEsE8UMJ0G6XjtYRyk76YOL167w5fZo9axF+qm9xrMS+Xv0DVhGP742M9hjL9uLsuDsffI4+DPOiao364WV/fWo2AFWj7pO66z/EUzH73kSaDMmvDJ39LOVLrY6TVISLaa3MBsCICaL/eKLvCTdq/S4TbsTUH09K359JhnwZIRyr/aMEDygrxIuZwkSl1iIm6J4HWZx6tuac7ATtH2PGcrYIb4mNwo//E1DkHTsI+6KamrX3KatSm9IjFgDNsdmnqVPK/Qz5RSaeDPOJWlCFUKgVDaJndDOA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m59RVKfLoVYh6VOhBHhZEZxTXm0EubVwNX97wZXaW9+9y5Yzf9jNeSZAkZJc4IVbAr/LqI+GEYTDzGXJhooOteu1/kbSJaB+JEaobVNGSLhovjI3Z6LlV4z+bEr7axScxyteLc7Y+Lmk8BLOZ6O2/lPItdOymPs1KEYxG7dCCP/lSokv1xJ2kzJFJgkj4wfDonHwlxhZBR+UXZyVmHk7nytMaNdP+cAZUpWmWxMwb0xIO7ylaxLLylV37c4uHgGdA5eEBmqmRCM1QcrH5v1SCqh5k0CSZnEMsUwFLBjTUjn57hcrewTdrr8WhuDavSfVD47LUuuCQZr6yDOFmL/cNQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 09 Aug 2023 13:57:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZypb0I6Psnfw1ike70N3zDUOJFa/h/VwA
- Thread-topic: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3.
> On 9 Aug 2023, at 08:55, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>
> The variable 'msec' declared in the macro shadows the local
> variable in 'ehci_dbgp_bios_handoff', but to prevent any
> future clashes with other functions the macro is converted to
> a static inline function.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> xen/include/xen/delay.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h
> index 9d70ef035f..9150226271 100644
> --- a/xen/include/xen/delay.h
> +++ b/xen/include/xen/delay.h
> @@ -4,7 +4,11 @@
> /* Copyright (C) 1993 Linus Torvalds */
>
> #include <asm/delay.h>
> -#define mdelay(n) (\
> - {unsigned long msec=(n); while (msec--) udelay(1000);})
> +
> +static inline void mdelay(unsigned long msec)
> +{
> + while ( msec-- )
Does misra allows to modify the function parameters? (Truly asking because IDK)
> + udelay(1000);
> +}
>
> #endif /* defined(_LINUX_DELAY_H) */
> --
> 2.34.1
>
>
|
