[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/misra: xen-analysis.py: Fix latent bug
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 30 May 2023 12:14:43 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xBhMHAkZErx/GU6fN/DbXKC2nygE+iNDHwbGjaN4MDU=; b=VqJLJSzUVT0mU3efFUoc81k35IcdZejBuFEt+3wQ+sSaZvoLegyjj24kCJw7XsrRzqZAw+p8KKCNeQH/WtDHjK9vC8yA2/+XTAwZqz1O6eHlVeCv9ZxkDvLwTKe09r2BWsSEN49pNqYbWXD+y40QOZZzWQ7QbiSomxU2tKX/A3j/lAxj+1GsOE5pBqBb+hUkwuTLL3GaGKBRoXjh6OTlplzpoWrBKEVaARacVIjnhLOD0Uyg5rD1o+9lAHDM1apAL9AQu5YwyPDMRW0r4igHzAAKy8+L4KR8+U6AGeadhPF37qUU8C7UKlk4vjZRNCrVbPl3b9WvQcW5VyHbpagR/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBmsWR7NcsvJK5cB7z/XKHIlp6oh0kZRl+ZwmyBUgRDBbg5eFgJ6RuFGDVoATjrfZHu9Lu7rLlF32+n81H68V/EhxQPvkzeJni8+SKLPcBc4teu7RWMoS5NCowqvmVkOKbVn8tUbhY/sO/Lb/cXRvw+DKfO9peaC3Ee5iEleu0r3TdKGozB18k8DksHgTDwY7tRhxvlKw8pClvBWW32N9k/LJhHzJhKaXSbqc9mVSf1kbgSPJqpmX9zG5SdoMcwued4ZuGx4oniLW0FUdzaqyUODsFnXUY28Byu6QxTgkEiwHVOhZTKMTK3wmDJWvtkhDcDufW+popJUV1x4DIRz5w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 12:15:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZijSdR4YxdS8bIkewpmkDG4LQH69yr6OAgAAciAA=
- Thread-topic: [PATCH 2/3] xen/misra: xen-analysis.py: Fix latent bug
> On 30 May 2023, at 11:32, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.05.2023 11:30, Luca Fancellu wrote:
>> Currenly there is a latent bug that is not triggered because
>> the function cppcheck_merge_txt_fragments is called with the
>> parameter strip_paths having a list of only one element.
>>
>> The bug is that the split function should not be in the
>> loop for strip_paths, but one level before, fix it.
>>
>> Fixes: 02b26c02c7c4 ("xen/scripts: add cppcheck tool to the xen-analysis.py
>> script")
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Just wanted to mention it: I've committed the patch as is, but in
> the future could you please try to find slightly more specific a
> title for such a change? The way it is now, someone going over
> just the titles in the log will have no clue at all what kind of
> bug was addressed here.
Sure, I will be more specific in the future, thank you
>
> Jan
|
