[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/misra: xen-analysis.py: Fix latent bug
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 30 May 2023 12:32:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ndw49eniBQQNb30Vo4vgHdAVfOcrEHVcwDEyZm9FUFA=; b=VF680DZJ7fl79LqMr5QkgFPCyXS5v5oi44iRUeGVT6PjiEUMu0JFsQzAOvu4NZg6zia4pSRmIcmc3AzgnMkDPkQ2fuHxH0PuO2lWde74aqYeYE9W/hqgpnoMbkvjtBXjUeDkDA+WkIYEArXxty5seLJ/e2hS7Yq1jhtsbsvme1XTvpzyomC5FxTyGUbb491p1riMXLpRn9pfpULfpkTEqprxbhJt9cFxiy8ES6kiooKieG4MB1Cab2BuuzeOn9wKKHiJdarWMYMW1APECdEaLpLHYopHSmrVi4eE9iY9ST/vljTSzJZp7qQn2hYek0hRmLI1UOQPGrUDsJ1n/xgs0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9i9US0zK9xH5w2cnI7k0L738tvs9uH0q+UnxtieeSvwHlPZBsrxMwWEv96/eGzDrwq+S6CQwnajiklBQLmDhM5X6eXEOjGmJ23DtEJGopyX4n0zz+0YnD9chqSmrxqpJymoe/nAZe7gDTKYdfPpjYFj1olUbBqFrbpb6LgJFwginMicNCHy4eL6SmRNmFF03u+CaCUSPH6kgQB+sV+Um2/8f8R04sq2TlRrauFKHcAwcBOBY1LCdUYN2KBIL3/pVP+f05jDo879NYzv2fMOrVexb4ittdVnQsR7EHPX+l3YE8g1ulTEBKERsIu+o6zM2aCHtLnniDeachVpf0ZcnQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 30 May 2023 10:32:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.05.2023 11:30, Luca Fancellu wrote:
> Currenly there is a latent bug that is not triggered because
> the function cppcheck_merge_txt_fragments is called with the
> parameter strip_paths having a list of only one element.
>
> The bug is that the split function should not be in the
> loop for strip_paths, but one level before, fix it.
>
> Fixes: 02b26c02c7c4 ("xen/scripts: add cppcheck tool to the xen-analysis.py
> script")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Just wanted to mention it: I've committed the patch as is, but in
the future could you please try to find slightly more specific a
title for such a change? The way it is now, someone going over
just the titles in the log will have no clue at all what kind of
bug was addressed here.
Jan
|
