|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH 2/3] xen/misra: xen-analysis.py: Fix latent bug
Currenly there is a latent bug that is not triggered because
the function cppcheck_merge_txt_fragments is called with the
parameter strip_paths having a list of only one element.
The bug is that the split function should not be in the
loop for strip_paths, but one level before, fix it.
Fixes: 02b26c02c7c4 ("xen/scripts: add cppcheck tool to the xen-analysis.py
script")
Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
---
xen/scripts/xen_analysis/cppcheck_report_utils.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py
b/xen/scripts/xen_analysis/cppcheck_report_utils.py
index c5f466aff141..fdc299c7e029 100644
--- a/xen/scripts/xen_analysis/cppcheck_report_utils.py
+++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py
@@ -104,8 +104,8 @@ def cppcheck_merge_txt_fragments(fragments_list,
out_txt_file, strip_paths):
for path in strip_paths:
text_report_content[i] = text_report_content[i].replace(
path + "/", "")
- # Split by : separator
- text_report_content[i] = text_report_content[i].split(":")
+ # Split by : separator
+ text_report_content[i] = text_report_content[i].split(":")
# sort alphabetically for second field (misra rule) and as second
# criteria for the first field (file name)
--
2.34.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |