[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] x86/shadow: mark more of sh_page_fault() HVM-only
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 24 Feb 2023 16:39:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Emg39pTfnI8nhGWBdriWGevupgKdOb/6oGg39CZ38c=; b=arTe3EkTtfnb0r9S5dv0iBYxqzWrx+6VS7s1zbmG30pGr/iLQ7Im1Itm4a9zl76xuVHO+Z6PvGvCanbpPs3rJt80CTlRkdvgEopw4lBIejvkVl5b7LmdFDygPEZY3uoJORveMD2i7ZYlM5fE55pS46dMkHGta9BYR2V5LoW5zI1zakUguzPUGrgQ/eUfK0u32v+qTO5zRaJZh0/Fk+ZtjAYN9ZAOta7iZHHMqbfanCdf265HoYi5k7cVJ3+P8GxUtaa3ws1RqU8liJttNwOvUeaUsSSbEPfQYFoH8n6CVdC5MK1WKp29+CAvBtib6i5KOFEA/FP86GZm1+Mop0rroA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYQ6zhl3wu7q3PRVzDhqPP41GtQnrp7Ktp9h+vC5FDMXXAh9/xiT7d09weiN9Z+XkYqXJx5AJItHu+BBBLcpMMNaOuRJZrW7xCMv+wzU4C5KQMdr8AFapzSGsLvSzAA9/mHLNuZRk+D1LA9bj8dCCkDJ1y9/QaAC6rNcu9G9zEleZG9hYz1b4isNq4dHT0Y8oH5ftQ8GY5IvD+8kkphGOC4mZQ7OCYS75GiVyAUfBU9WQ+PbOwgiFU+BZhJoVJ1/Ip80Kc6YcYFrynkmybkxDi1hIinev1ulDdAnyAkxsX3w/VSKD5p2+G8Zg3XMY1MPrwZsb7wTdpvLyE/ziKe0yw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 16:40:02 +0000
- Ironport-data: A9a23:8pHfUaL3sudoiLGqFE+R4JQlxSXFcZb7ZxGr2PjKsXjdYENS1TBTn zFNXG3QaKyOa2XyLthzaNm09U1S6MCGyNU2TFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c52IjFk7 qwmGgoxazedm9Om8qm5b+5z05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHOnBNpMROXQGvhCrXjO2TY4ARsqdUqEmuGnkW2ge8xNA hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9UQAJLGoqdSICCwwf7LHeTJobixvOSpNvFfCzh9isQzXom WnV9m45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 xDoR+D2ADgyMKyw
- Ironport-hdrordr: A9a23:5GpK9a9lqNaHEYXvx2tuk+AVI+orL9Y04lQ7vn2ZLiYlFPBw9v re+8jzsCWftN9/YhAdcLy7WJVoIkmskaKdg7NhX4tKNTOO0ADEQO4N0WKI+UyEJ8SRzJ8/6U 4ZSdkGNPTASWFgi8D0+Q+5FMtl7uWm3cmT9J3j5kYodBptba546Qd/F0K8KW1ZACd7JbdRLu vg2iJgzwDQAgVpUi1+PAh8LpT+m+E=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/01/2023 2:27 pm, Jan Beulich wrote:
> The types p2m_is_readonly() checks for aren't applicable to PV;
> specifically get_gfn() won't ever return any such type for PV domains.
> Extend the HVM-conditional block of code, also past the subsequent HVM-
> only if(). This way the "emulate_readonly" also becomes unreachable when
> !HVM, so move the conditional there upwards as well. Noticing the
> earlier shadow_mode_refcounts() check, move it up even further, right
> after that check. With that, the "done" label also needs marking as
> potentially unused.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
