[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] x86/shadow: drop dead code from HVM-only sh_page_fault() pieces
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 24 Feb 2023 16:40:55 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7uTl8tMvLaSfDKTxdpBnAX0uS30zHEFtm5N9vI+5thQ=; b=n2opfTAMTXy8ooKS5XcNcVMQIuLyw8KOtSD50iM9scu+RX+v63p3oRF8im5f4ZB2o5/7AYzUxDTZe6SUgRds9tiul8vraoSPgHyIHwpqArdH9Vczc3ng/pzsFGUH2v2iPrB2Gecd2ZeoSKQXbGDnmqFp4oCt8C+tsEfDFOO2Wps46zhb6s15C5LHiOyv88lWXfDQcE1rLEwEQTUuyCMeBfDeRa1DE5ZidMQVnih98BoQw5VXdYaLic9cW6yBGkFgrxbQHVvg6L2PCW9Sg53NNj5yl7iIRaNQ1BeeWnaT4FhWvtEayEr4wEYJs85rOebO4ryoV1vJwNO61n5tMzo88w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4Wp2PThvPw5QHqo2Xc4zoYNW/Nkx6wV1DrhM2nP6dZjtvlXPB/5w971H75FTUMwHKgCYz1koQBPFPAezuSkNR1gYigd+Ti7CttJB9c1HKpqFNuNTwBjqGscJzr97oRC+Ixhn+WA53/KWcQ54H6jFKEh7TenOSL5z2mRQB6+/5Y3z99wmFunAxsi53iwFY+27HmR9RlfO1IkLeDzol5fAH759fvWggDFG6Th8Q3IycrfFqZLfhV7LvqEm+z/vdIqJjH8O5B0oayvr/0VZ153aSx2+pZqH8FNbCKQwQME7Lu5Zubnswm6jsee6ZkChhjE/iV1V3rw0lNrkKtN6+tHIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 16:41:22 +0000
- Ironport-data: A9a23:Oeg1C6KMa8bFrK+cFE+R4ZQlxSXFcZb7ZxGr2PjKsXjdYENS3jUGn GsWXjiPP6nZZ2ujKYtwa9+0oxgA6pfSm9A1GQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lMFwfr MM5dgkcbyChmLqVze2idORF05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGNnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHujCNxJROTonhJsqE/U4VJMLDgcaUqQp+jjrnKBV/diO 2VBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkA9MW4HTT8JS00C+daLnW0ophfGT9ImHKvriNTwQGv02 2rT8nh4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CJsdxS2hAzWMaywqQ==
- Ironport-hdrordr: A9a23:tLQpRKr9VwE8DRBKSp/2/8AaV5rmeYIsimQD101hICG9Ffbo8f xG/c5rsiMc7Qx6ZJhOo7G90cW7IU80lqQFhbX5X43SPjUO0VHAROoOgeSN/9SKIVyaygcy79 YCT0EHMqyIMXFKyf/g5g+2CtAhx8TC3pyJqI7lvg1QZDAvUrpn6QhhDAadDwlRfylpQbQENL f03Ls7m9KHEU5nFbXFOpDAZZm61qH2qK4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/01/2023 2:27 pm, Jan Beulich wrote:
> The shadow_mode_refcounts() check immediately ahead of the "emulate"
> label renders redundant two subsequent is_hvm_domain() checks (the
> latter of which was already redundant with the former).
>
> Also guest_mode() checks are pointless when we already know we're
> dealing with a HVM domain.
>
> Finally style-adjust a comment which otherwise would be fully visible as
> patch context anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks for splitting apart - it's much easier to follow like this.
|
