[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] x86/shadow: move dm-mmio handling code in sh_page_fault()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 24 Feb 2023 16:37:39 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FgHb+kl3c343dpaFQUqBPUninPZYgF4SgVkufcJ8BjI=; b=lYyGagMrRQfcyRNz3m5ptWl60l/250w0WVejc97l/LHDjf3UHe+uGaB9z9uhC78gv99AbzFEO8OF6jUwhbksR6YZHbHQUkcHQdRSv87/J1CnHyQJgjLj60bT0oWFUEbrJ/ztPv5ML4gSs1nlX0cfj3+z58b39axr1qINZTT5EdSGVVuRqnI0PDUDTnfTz6Xmy4DYyyjZ0l4EAAwwel1NcxowsjL5oYtaUKSdoOjZippCQ65WU9JpA8owyL56yymDC7L4soj7TVwoOtl6ewWeYPxfOqDJJsT2xBSk+pqgtzwAgjfP+pFrtyYyEf0BZVMOeYJL07j9jMS8+pSfoqJFqA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPl2E8nLvzFGXzWIW4FeWnj7H6jZ9oxR4ASvsNShwFIk7GuLehrqHVNURv0aX9KOZ4EHUxOH/aCsHfevM+Mq3IbqDdNFnhDdxJW4VLZiVZBNxs0eXiuRMZzrkUFd2JZNqsFjK70nAOUJJ0HGI5jtEtaaENjyhKTytk5vdK/vlYdCnQyQ6NJqt297PjL24tWNx24Zhp2lWCM8IKqFYxVjRY4KcMzrf/bJYmAPs9ekBunCxgZkkMTypoVIyhu9Cs2lL+dcBvLOqVI+VggGa31Smo+HEraDG4Xs+yI0sbNGmCvYRN6lvJ1DmoRMJi+bk7Gj8nTgxDi4Ow4A3CvaHY9iPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 16:37:55 +0000
- Ironport-data: A9a23:sr6Ei64JLAqVmCOZqPXCdgxRtAnGchMFZxGqfqrLsTDasY5as4F+v mVKXWGHbvmOMDejeNh+aozn9UlV6sPRxoQyTgJqqy5kHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 8MCFBAyNTG/oOvo37ziae9n3eMvI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNCT+HnqKM76LGV7kIvECEVW1eAm9eC1nOeV+AGB k849DV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqeS4BZRsI5Z/kuo5bs/7UZtNqEarwgtirHzj1m mqOtHJn2OpVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ==
- Ironport-hdrordr: A9a23:njhBQqqtYpSeru2i9zOW3DYaV5oWeYIsimQD101hICF9WcaT/v re+8jzsiWZtN9xYh4dcLW7U5VoLkmzyXcY2+gs1NWZLWrbURqTTL2KhLGKq1eMJ8SUzJ8+6U 4PSdkbNPTASXR8kMbm8E2ZPr8bsb+6GXmT9ILj80s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/01/2023 3:08 pm, Jan Beulich wrote:
> On 23.01.2023 15:26, Jan Beulich wrote:
>> Do away with the partly mis-named "mmio" label there, which really is
>> only about emulated MMIO. Move the code to the place where the sole
>> "goto" was. Re-order steps slightly: Assertion first, perfc increment
>> outside of the locked region, and "gpa" calculation closer to the first
>> use of the variable. Also make the HVM conditional cover the entire
>> if(), as p2m_mmio_dm isn't applicable to PV; specifically get_gfn()
>> won't ever return this type for PV domains.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> v2: New.
>>
>> --- a/xen/arch/x86/mm/shadow/multi.c
>> +++ b/xen/arch/x86/mm/shadow/multi.c
> I've sent a stale patch, I'm sorry. This further hunk is needed to keep
> !HVM builds working:
>
> @@ -2144,8 +2144,8 @@ static int cf_check sh_page_fault(
> gfn_t gfn = _gfn(0);
> mfn_t gmfn, sl1mfn = _mfn(0);
> shadow_l1e_t sl1e, *ptr_sl1e;
> - paddr_t gpa;
> #ifdef CONFIG_HVM
> + paddr_t gpa;
> struct sh_emulate_ctxt emul_ctxt;
> const struct x86_emulate_ops *emul_ops;
> int r;
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
