Re: [PATCH] tools: Remove the use of K&R functions

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

Clang-15 (as seen in the FreeBSD 14 tests) complains:

  xg_main.c:1248 error: a function declaration without a
  prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
  xg_init()
         ^
          void

The error message is a bit confusing but appears to new as part of
-Wdeprecated-non-prototype which is part of supporting C2x which formally
removes K&R syntax.

Either way, fix the offending functions.

Nit: This says "functions" (plural), but I only see one function being modified in this patch?

Doesn't matter too much but might save an archaeologist some confusion if someone were to fix this up on check-in. :-)

 -George