[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC] xen: Work around Clang-IAS macro expansion bug.
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 17 Feb 2023 10:37:53 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxNENVWF8iIo6WjdZsWWx3T8vnzZOKV0t+7laPKuVoo=; b=HwOkLmkQlecLt0MdHvUpUicc/jE4mVrIm+em1KIQeYacEOsuMp5zluoxfO/ng6BoUD6MMltRbNkfw+i8dp83zdV2pT4LL0a0fgonu5WjCPYikJwchW9mH+Q3B0QIW2msUz3CpQBeToICP4Y2IRrg6vpwSao0CqfE4nIiFiAyXF6No3Sb9h9jmS6Hb8vJ8QCZ0JAmG7ytgpJk5YCQ6q2JsWf8SSZM2mlEfaveOsPqYkvm4LBMpZVbspTNZ9wWXvwj4zohIspX3EQt7Obxp7ukahej78y00li2V6+zuwaxX2pWKUC0DMe5b7qqAWGDtdMd21M4nQA192pIz2vSupGL5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGrPnsLjUE4X7wDSpLkOc3vMbMNcclQXJW2Be7TnLeXl0Q6L1HzsfRRU6Z2/bg5TJjMCR+N+56mKyX1U7vvOWgYwYKdx1eeunGKfvpVbMJNOVMppC+goNWKUtPIXceicQDUsrvki7puE5mXhY18RUSd6rCuTrpGN+iQLenFfCFsicCcT64TBKkdt15rplf6GgaIqAuQCLt+SRmwB9z+vT88FQxb7t2zOA+M3M/pndJUcvYwOOxG7EWQkKn9JHEpb0Iy2sOc6pr8O1rSV/XsPOojOXYWpHStKL9XGztVqyXZ5CtP5uJksGW0H35onv+HtXms1ZbtmAbgnf4krknIajw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 17 Feb 2023 10:38:20 +0000
- Ironport-data: A9a23://cwO6i7XeU0oKT1YdjWu3LCX161QhEKZh0ujC45NGQN5FlHY01je htvWmqEP/zYM2D9copzPY/npx9QusOExoBlGgpkrHxmFSsb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaBzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQnJysWShWhmNnq76vrQao3t9oBKfjkadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyarI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RezoqaQ72wH7Kmo7FyEpfkC88aKAuxCndtx0B U82/DACsv1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebR4A2 0KNntjpLSdyq7DTQnWYnp+LqRuiNC5TKnUNDRLoViMA6tjn5Y020BTGS485FLbv14KvXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU=
- Ironport-hdrordr: A9a23:WjOt0q6OQQaki13LLgPXwPXXdLJyesId70hD6qkRc203TiX8ra uTdZsgtCMc5Ax+ZJhCo7+90cu7MBbhHPdOiOF6UNuftWHdyQmVxepZjbcKrQeQfRHWx6pw0r phbrg7KPCYNykCsS6wiDPId+rIGeP3l5yVuQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/02/2023 12:19 am, Andrew Cooper wrote:
> https://github.com/llvm/llvm-project/issues/60792
>
> RFC. I very much dislike this patch, but it does work for me.
>
> Why the parameter name of foo? Turns out I found a different Clang-IAS
> bug/misfeature when trying to name the parameter uniq.
>
> In file included from arch/x86/asm-macros.c:3:
> ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no
> following hex digits; treating as '\' followed by identifier
> [-Werror,-Wunicode]
> .L\@\uniq\()fill_rsb_loop:
> ^
>
> It appears you can't have any macro parameters beginning with a u.
It's worth saying that I can't repro this in more simple setups, so it
likely specific to some of the gymnastics we do in asm-macros.c
Also, I was hoping to try and sort out the macro such that it had
.macro ... uniq=\@
reducing the internal complexity, but I couldn't find any form of that
that GAS was happy with. Suggestions welcome.
~Andrew
|
