[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Remove the use of K&R functions
- To: George Dunlap <george.dunlap@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 17 Feb 2023 11:12:41 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qptmatrl1jrfmwiJYqpMfXHZ3BDToA7+rN/yVyHhoTM=; b=jrvYnH2tLZ9f4bSEkpFUEwLnlZDw/HwgNg08Rsib186ZjShOLi0t8VrmVjJYSFUK0qQVHKUwD795eXFv37c2oimKUlg5qd/9cPkCm/6UHtEvel4CQ3TABEfg/Fazr1YIZllWa72IMKEKb59zJEm3cz1g3qx+Vk6mSSse78jbBhvY5e+WCqqgn24Bkdv97mLXy62btm8BcCgHl34H47XghbbgN/L4lOaoy+XGG6BiUqD6DvHcQxQErkrps1Pr2nmmyqj9xeFOs4NLd47tkAIYQ7WVf+ZjM9o2LOM9mQUbiWkIqrtPz1O3T+PTGS2lxYMVcKbH0DKoKk3h3M3AEhtdhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRDBG1ObGV/YFl/O9ivrmaiCUVyYL4aLkMogbgw1OHfU2kLJElEIQolKyk5NgjIV62iXtaNZv0sSkqvzLVNjOyP1NrR8SWCAm/ZFCkaa+lEVgg81Y1CCwncm2478FC84qs3LoZIxUUxB1s9L6ISENFvSIQ4xUl4/5zfVofAsEMmFH8Zhd6WBZ1xUCN2N4Ntqp/ZZOpcl86ViCpvDdC4UAMvgEQV3UT6Nz4ogKjdMmHNzq8HZKDssOuh+D2qzkNVLti9v4RaDSBtyl2F1EVEi9L/5cR7+nJud+eJuvMKWofb3iuvPhe4s9CPaFq+0gXtk0UBXU/IMnIG2LnApsc3vpg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 17 Feb 2023 11:13:08 +0000
- Ironport-data: A9a23:xI6trK74p4KTQcyor+T+iQxRtNXGchMFZxGqfqrLsTDasY5as4F+v jdLCj+BMvfbYWL2fdl0OYy38U5UusOGxoUySFQ/qSo0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 M5DEjcGNxe5h/OG+5iDT/RtjOUaI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+CF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMROHlrKc76LGV7kk8UScPSgqrm8aaqG2VYI15N kow9gN7+MDe82TuFLERRSaQr3ODpBERHdZNFekz8CmGzq3J70CSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaGwIYMGsDbi8sVhYe7p/op4RbpgnUUt9pHaqxj9v0MTL92 TaHqG45nbp7pdEP/7W2+xbAmT3EjprUSg844C3HU2Tj6Rl2DLNJfKSt4FnfqPpFcoCQSwDbu GBewpfGqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI=
- Ironport-hdrordr: A9a23:YkNqWq04kqULmW3N7dN8oQqjBGAkLtp133Aq2lEZdPUCSL3lqy mLpoVh6faSskdoZJhAo6H4BEDkexnhHPFOkOos1NuZPDUO/VHYSb2KjrGSpQEIeReOlNK1jp 0QCZSWYeeYZTNHZITBkW2F+r0bsb66Gc6T5Nv2/jNEURxtcK146hcRMHfnLqS0fmV77FgCea Z0KvApm9NoQxoqUvg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/02/2023 11:10 am, George Dunlap
wrote:
Clang-15 (as seen in the
FreeBSD 14 tests) complains:
xg_main.c:1248 error: a function declaration without a
prototype is deprecated in all versions of C
[-Werror,-Wstrict-prototypes]
xg_init()
^
void
The error message is a bit confusing but appears to new as
part of
-Wdeprecated-non-prototype which is part of supporting C2x
which formally
removes K&R syntax.
Either way, fix the offending functions.
Nit: This says "functions" (plural), but I only see one
function being modified in this patch?
Doesn't matter too much but might save an archaeologist
some confusion if someone were to fix this up on check-in.
:-)
Yeah, I pre-emptively wrote the commit message as tools-wide. Given
4 in Xen, I was expecting to find more than 1 in tools.
I fixed it up on commit.
~Andrew
|
