[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Dec 2022 13:44:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+7o+XQPnfiubpfrXDvLjxyBS5xWTsFO8ZApZbBkb2I=; b=KZANppFMLktpixX/S6aL61KLLj6XUeHHOW3RQy7SQkD2CdBbDwUkUguSSfhzWR31jGBUIL4iZnP/WwP4hO3/nFNMsg0IAQ98xKWuSi9W8lhmQrJkWyhBSvLhVN09Lk6cR7lpKXnW4mP8q/3LHrhn+jMrAbfGv2712TZo8J76wCtJRT3CrSGWWjj+KG6hQMFfm0qUAfrptlFaBYvP+Robd9pR5D2qBgNTlaCJ3b46IFE5wPkBfucncfL9/+kx/Imr5fpI+02fpHbFADpw8i1SZYqz6ERvUqrD9HQ7WMR6XtRy/OWbDavGtDN6PzricSjBg4TSJbx45wvbJSnZ/TBqsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xxl/pM8kscnw16SFRva3tAmIINE/WYViaosIm9Z4gDnzoaLavWEsICqhyHAYcudKFQZz8ShodJ2m5IiL1RH0BGa2naczij+c5aP/5BNFHOjg+o9XGdSRk1C1Sp7yqwRGVjH/38JQqGIKCBFOb/q7Ug6VwRZLC2Xc0DLmXIM+jEROX1tzEEHT6hNomCCYBuDFxAaQOh+oxVD+Gu7z56VhiOBMSa0DciDfmpAnbmc9BiLqrpq/qM1s4+lLp/xeq9n4neGHZoQ99REruNxVV9rn9Y73Fnj7GQJuPLAKqsVeHL00ngiRVxF9hnX9X6DdUNM6thl5JoiC0am2GuzwULes7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 12:44:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.12.2022 13:36, Luca Fancellu wrote:
>> On 5 Dec 2022, at 15:58, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 05.12.2022 16:40, Luca Fancellu wrote:
>>> The script xen-analysis.py is going to be used for the analysis with
>>> cppcheck, so remove the rules from the Makefile
>>>
>>> The python script xen/tools/merge_cppcheck_reports.py was used by the
>>> makefile rules, but its functionality is integrated in the
>>> xen-analysis.py script now, so it can be removed.
>>>
>>> Remove some entry from the .gitignore related to Cppcheck invocation
>>> from Makefile
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>
>> Is this a proper revert of one or more earlier patches? If so, you want
>> to say so, for being potentially relevant for (at least) review purposes.
>> If not, it would also help saying so to clarify what is being kept.
>
> It is a partial revert of commits 57caa53753212 and 43aa3f6e72d34, I’ve
> reverted only the Makefile changes, the xen/tools/merge_cppcheck_reports.py
> script and some entries in .gitignore.
>
> Should I put this in the commit message?
Well, if it's a partial revert, then - as said - it would be helpful to
clarify what pieces are kept (and then also why).
Jan
|
