[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 6 Dec 2022 12:36:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jmuujFdJHmxkOO2QXwGOMXKNJTrnAflI5gRLPmamlQY=; b=oJrSiwQCZAgZEOv9jFi39WyfOeiq88QqKhy1dKKPUjPKBo+WwoW8AVSJ8aNHrwboqFoSJ11jFzDyFq/zwXYjOKJUR3NHESbUsg+GZb54DnR+sJkmfIZRi93rfHwCjIyQJhR3evRMkws8We9usGQXmXg+m0Q7uJzSgZ7qRfCbb3GHvZu8VKQTWOoyIv91VizbTO4dT2+cUIXxJn0inXXjwJXbSLrhTPOUqcLTZ3rGFcy1Uj84oS01iHEtzYHjV7CQRUrudgshjvQ+6sVrE+gQbajBvnuxJjGucWsjw8jaJJ496w3Zgk5J99O3poROmCx/OFC7/tHh8mchKb2GcSzBUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hP0UzH7s/HulhiCELiTFFEg+9klvjkq1ip7x+CAvnB+x9LeTWGi6Ze9GHAx+V+3dxXHEqR39dibD6seDSUu7gglIP7CmDEeqshof+z/o0GJGk7Xk9Dj8gxTRj5dOzBvlfSdNtH503z7AdjmV1w5y2zUYiac/6GxzBWxs6fibHCYma3ucCTDletofxXB7Jv/Z2bY6Hecz/M7eB7mIG6wTRJp/Djgfeu+Wrj3oKYeGQ5D9JBJBcvctlztBrE7nFxC7QATw+KfRxTqi+5KaztA/b+5R0giSWYQvOJIHwMQ8ODT4WFcE/xf8Em8DuM3BoUITdj8WOgRrWvL+n2QXdW0lgQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 12:37:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZCMAWOgBUls/3J0ScrSjGl4ZC6a5fcz2AgAFZ8IA=
- Thread-topic: [PATCH v2 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile
> On 5 Dec 2022, at 15:58, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 05.12.2022 16:40, Luca Fancellu wrote:
>> The script xen-analysis.py is going to be used for the analysis with
>> cppcheck, so remove the rules from the Makefile
>>
>> The python script xen/tools/merge_cppcheck_reports.py was used by the
>> makefile rules, but its functionality is integrated in the
>> xen-analysis.py script now, so it can be removed.
>>
>> Remove some entry from the .gitignore related to Cppcheck invocation
>> from Makefile
>>
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Hi Jan,
>
> Is this a proper revert of one or more earlier patches? If so, you want
> to say so, for being potentially relevant for (at least) review purposes.
> If not, it would also help saying so to clarify what is being kept.
It is a partial revert of commits 57caa53753212 and 43aa3f6e72d34, I’ve
reverted only the Makefile changes, the xen/tools/merge_cppcheck_reports.py
script and some entries in .gitignore.
Should I put this in the commit message?
>
> Jan
|
