Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32

[Julien Grall <julien@xxxxxxx>]

On 23/11/2022 10:35, Michal Orzel wrote:
> Hi Julien,
>
> On 22/11/2022 21:31, Julien Grall wrote:
> > On 17/11/2022 13:39, Michal Orzel wrote:
> > > Hi Ayan,
> > >
> > > On 11/11/2022 15:17, Ayan Kumar Halder wrote:
> > > > Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169
> > > > Affinity level 3 is not present in AArch32.
> > > > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106,
> > > > Affinity level 3 is not present in Armv7 (ie arm32).
> > > > Thus, any access to affinity level 3 needs to be guarded within
> > > > "ifdef CONFIG_ARM_64".
> > > >
> > > > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> > > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> > >
> > > although, IMO the commit msg does not reflect the change (i.e. you do nothing
> > > related to accessing MPIDR, but instead you are just not taking the Aff3 into 
> > > account for AArch32).
> > > Also, I'm not sure why you used VMPIDR and not MPIDR.
> > +1. Can one of you propose an improved commit message/title?
> Title: "Do not calculate affinity level 3 for AArch32"
Sounds good to me.

> I think the commit message can stay as it is.
> > I would be happy to update the patch on commit if there are nothing else
> > to update in this series.
> The series requires re-spinning anyway so no need to update the patch on commit.
Fine with that.

Cheers,

--
Julien Grall