[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32
- To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 23 Nov 2022 10:35:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w1Z0ulfy2zznqdIdy3z7j/WsoVF/LjxWP35bDf2X2ck=; b=b0uoCs1ofsNbW46y9lOzjsT5ZCkoxkdM95ALkLfPViYrHtd34ulf2Xw2UMZR2OY1nvwdS699xw+tpLT/oRYEe4dDBwrdzcBaTUAuSo3LOl8Qoxm76EgQe5xkTnFZtv6/g9eGiJluIP90xVAwnan623F79VSU0iQpRIFlV4VGK1TIGR7Jw5AlOUUgWOgbogykUHb1Ly7naYSAYqhUGy5HFrSoGm0MgXxoqoSZ+CqjvVa07WFK5GK3Wwwwn3L6I30nItgxs+fSWm42/551dSsfj7RWfEvn1bQDJ9UGccqiTZNqtMfrG382l+ZRm3u2VL7teOi6pUDXlyfFUznO1uDE3A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1b5/s4i/Zv9yiO1K3WypKf0Is4wPTxAGJ8dp0sXIoq58YukV5iYpkfwItOPm1VQ6H58BmLToZkd1xpXhWGJMiEaLUHNOQXoaSbVE+FMBAyZfW3c1cYihLZEfSZAfdrUlJLoC9c9CtVHeGspQjrRelKO45eMkEo1DtLtiygC8zhg0kKJOmPxd6NnQq/Zr2A2SAvBRQ4AzMSicmhLu8TMFl8MibxiA8wLr7rxgh6B4q7VyCAokY4qGYaFoG2DGD2yfxQJWY1dE8Qza+XxC09mTCz33DYXRLBktLlSUnWu4KkDdpjy6z8UlJzGAMQ3rA1JNl4fDmeH0HOSF2yJSzhUuw==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <jgrall@xxxxxxxxxx>, <burzalodowa@xxxxxxxxx>
- Delivery-date: Wed, 23 Nov 2022 09:35:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 22/11/2022 21:31, Julien Grall wrote:
>
>
> On 17/11/2022 13:39, Michal Orzel wrote:
>> Hi Ayan,
>>
>> On 11/11/2022 15:17, Ayan Kumar Halder wrote:
>>> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169
>>> Affinity level 3 is not present in AArch32.
>>> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106,
>>> Affinity level 3 is not present in Armv7 (ie arm32).
>>> Thus, any access to affinity level 3 needs to be guarded within
>>> "ifdef CONFIG_ARM_64".
>>>
>>> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>
>> although, IMO the commit msg does not reflect the change (i.e. you do nothing
>> related to accessing MPIDR, but instead you are just not taking the Aff3
>> into account for AArch32).
>> Also, I'm not sure why you used VMPIDR and not MPIDR.
>
> +1. Can one of you propose an improved commit message/title?
Title: "Do not calculate affinity level 3 for AArch32"
I think the commit message can stay as it is.
>
> I would be happy to update the patch on commit if there are nothing else
> to update in this series.
The series requires re-spinning anyway so no need to update the patch on commit.
>
> Cheers,
>
> --
> Julien Grall
~Michal
|
