[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32


  • To: Michal Orzel <michal.orzel@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Sun, 27 Nov 2022 13:32:31 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AI6Bpawt/zYRo2wBr5OsW0H21+PjSq4U8+j/r+iLFGs=; b=GkcJJIDIQHc0Dr6qJBEhagfrzTZJe88G9YFgpLHrbbj8oZ7xBy4z2PfO+Dph1+Se60D2ArfP8jCd/t/tYZmCXySE3RbI7oRiHd2DkTTvU/Fiqw/arXAeLgTygdqiNKOUpUPlSmpLaEg6xxLRUBEklt4COvDV7uBZYM42PdeiOgxdkdQ7DwChtgdCRo468w4ky6bsTE92qyzKZTiF5GtDWqbj4LuVIunnhIVQTSj7GChzXgZnUNmFMOGqSw2I61CxXE6Z8KjuKytTX1HmOPDJsmZLq8h6YYC0zQLJZYDsAak0r2bU9iEVZXN5TFXf6aCwAcHmxbIqeM58V53Q4yKh8g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnkpVN0hdm86QEfUMAz7+46VHO84Ff/w5undHcCdwkrKxwa2OXo95WH+JNV+vhZZqfcMMJqhWYqBruHLF3ZT57ElKxjcWZ12wIOkhI4D4rP0YUA5iDTqlD+/weGNNFvtjr9/+RnCzw3KznTWMMeEBN1l54fnoNsiMFBI87lessrk2Pwb7nIptFx4ZcP6s9Ke+DGtBagHonHQ7b3RmGi/Pd4zE0tURG5UqPsIa8zel0ppJ9UMqdpACP4NumlxTHe5RE/prD6nig1kemkIs4bcWXDAzVdR+fWAZKkIUVX87j2BW5Ju3hgK59SYEp+iMjvInaMDuEJB/wT3Qr3adiXXWQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, jgrall@xxxxxxxxxx, burzalodowa@xxxxxxxxx
  • Delivery-date: Sun, 27 Nov 2022 13:33:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 17/11/2022 13:39, Michal Orzel wrote:
Hi Ayan,
Hi Michal,

On 11/11/2022 15:17, Ayan Kumar Halder wrote:
Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169
Affinity level 3 is not present in AArch32.
Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106,
Affinity level 3 is not present in Armv7 (ie arm32).
Thus, any access to affinity level 3 needs to be guarded within
"ifdef CONFIG_ARM_64".

Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

although, IMO the commit msg does not reflect the change (i.e. you do nothing
related to accessing MPIDR, but instead you are just not taking the Aff3 into 
account for AArch32).
Also, I'm not sure why you used VMPIDR and not MPIDR.

Actually MPIDR in EL2 is known as VMPIDR. So I used this name.

ReferARM DDI 0487I.aID081822, D17-6354,D17.2.152, VMPIDR_EL2, Virtualization Multiprocessor ID Register

- Ayan


~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.