[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Wed, 19 Oct 2022 06:52:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=; b=XXAbXXw9QRlFCoxjjDbF5PH+UJwlFouKWTJ01n0LIYzjYhZfIGuf+5jVqldfSRK1NakwNGFl+KetLe+c98iKJBatszYYut1TxdAhwqSuJvsZbNcmXfvFwiPDndRBgraaD5lPpEyBlFZ8sHJQ4HtDgpnhbVfL0HeS0KIK6exvc6sx996j8f8qeRX+vU+h+YXiq/ugh5m9OMhkQYOxrHGkZ4xMrskx3y53Qb1EUZKqxY2ht7NSjpktnq/SCWJxRAelAYN9s7NHIdyn83HamlZ1wiU5P/wIR/v6LBQ5JfNrGsAQ5J7OC0CUdm3quCqkyUQuLz8BSUykzW7so/nLMjjZMA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=; b=chW7nPwEs7noyV3G7lndHEZGLCyeV3AJsPIwKLE0nSyRXMxa6/uOYRzaKEz0ip9bD3nJrwJmAYvZ0JIz0qHcW9g1PWonhrfzIMhuTKMJhP7/hxHl/uLZOiQbRnnoNiWO5/R55YGnD9Tvmva9/TZvqswvewAyoUrH1Ik1CCSEjIxVId1F0H3zWDZAVNAH2eWn6zx+azW36BSzC2WvuKgyITg9YV52uTc2fRQ+Jq6gSBGvSpl7H791728QQJchR5IE92eNVNYxuIfjPmi4exE66nuptKIB3vgHcL8hcAxjU790B3G7h8QaQl48f+83hzlcLDmxc71erBIIxY2L/Ua6oQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OERFSsBRViJuB22lybDSA1j6eeJ2D7HtXNvht7xDHv8IjUI/jPAedJapE96poCZsn06Knee9OQs3G6C6FjFGrUfbMJh3IENcuPvkaS75rHklt81cqczrI+AnzQB19GRG18i8Boy3W2MaYkmqzhvArp0Iaf63gJzsU8Vs93qVbr1L8CSPOF9jEtn/p7iLed8J435UD/KkJOZrUoufAqB7cNNZUPSDiGkldjg9DnlTpMwhv3jbzB8WyYyoOF4MdtKUD/7pcgBGPeZCVhJcdJeWq7VACo2z8otoeWuHzBBcx3X3BP7inQBHysOsn5R0o74Z65H35jmqbTbs7/U/f0r+eg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N2i5ko04O9VjVDa5MVtTtJZY4RSykTMBecxcRBfMMSIR65+ADHEPJIa3oUxDoEN8xI+8Z5X8uhTHJMehzKwNV7ZrflMcBjikSxrkiSbFBvwApgxVwGrmULDiTV4vEBvWqQ36/39T3AFYVmAvnQJJqzCcvC76EZgupcJ1bIbXSG5IWPQ383fWwAYEukBYKKLaTViRLGwol19QGh4eqWBPtz34Gym/95oYMbc8ghuyfcSzs/ANjVrjLBa7IH5KlqRHY8KjOUvtD8KufmMKqmLBs4kOEJm50kXpNCc0lpMgYP6LdzpQUQ9UUaH7BDikMW4LVnScIvDCYXMz+VLWruJeVg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 19 Oct 2022 06:53:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3WMXl9OYk9SO1UmCbrdWlsAFLa4UNRwAgADISRCAAFTIAIAAAK4w
- Thread-topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年10月19日 14:46
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code
> from x86 to common
>
> On 19.10.2022 03:58, Wei Chen wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: 2022年10月18日 21:46
> >>
> >> On 11.10.2022 13:17, Wei Chen wrote:
> >>> +static void cf_check dump_numa(unsigned char key)
> >>> +{
> >>> + s_time_t now = NOW();
> >>> + unsigned int i, j, n;
> >>> +
> >>> + printk("Memory location of each domain:\n");
> >>> + for_each_domain ( d )
> >>> + {
> >>> + const struct page_info *page;
> >>> + unsigned int page_num_node[MAX_NUMNODES];
> >>> + const struct vnuma_info *vnuma;
> >>> +
> >>> + process_pending_softirqs();
> >>> +
> >>> + printk("Domain %u (total: %u):\n", d->domain_id,
> >> domain_tot_pages(d));
> >>
> >> Perhaps switch to using %pd here?
> >>
> >
> > Did you mean %d for d->domain_id here?
>
> No, I did mean %pd:
>
> printk("%pd (total: %u):\n", d, ...);
>
Oh, I forgot to change "d->domain_id" to "d", and got and format error.
It works now.
Thanks,
Wei Chen.
> Jan
|
