[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
- To: Jan Beulich <jbeulich@xxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 19 Oct 2022 06:50:10 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=; b=HTRS2hJIhe0HReacJtdBBUQBUyFn2jn+MXh2WKzhqsWOs3TmQzzZthf8X912P3rOkTHcmKOslTlIKWJZlxayc5vHCwoLrFt0RnRzZ5a4S2FsDahocHLPTnWenPKe58Rl6OaQH6ufKRcNzz8ro506l7T8f/8mOZMJL/JFdzv26jpep/pTcYhqX7/QDbXBlfYVhyfuR5D36TPy0ECJ0YVlO3tsui/jk86k94+56DEq/EExowhvmMNL+re3pdg0fBt8AskANNF9HD6yx6tRJZRCCVYCyDrodZx2PRhEGV4klZu/BFdqjVvdujpYtvXVpCloDguiy9/vMIfsBWIfUdpLyw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=; b=YPl9xLF+8Lm94d+lCJhHqbeP+0RN5ULGHG8kHkFvfiX5blI7ZbXnUXjHRs1Oh8AFQAarVrjiTkZqoMasLVVSimwg9XZdzmjdCme6LH2fJVtUpayDFO303IB4ugbN6nVrcBKbriJ1Zr2mCdWkstgFiqQnXz0f52MN7xlUy28iiMBe5NR++b53Ew0wd4FRwP0XwlEVu1F+2r16N0+dOFLs8XwkdHXbaAeCgmkuLdCOEmo9lnnUoim0/ULVT8KwUPJXQeTd1/ST9rnKHwl62tg43lvZB41Oy8ZiTCo2HdHczcHF8EzuH60Sjb9NNCSpsH+BdtlM9Ygv42j6KwoGxDXPqA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RNMVXRL9vHrSm//K9mOvLIqdvWBI7VeXU4oVGazG05uc5I+Hg5CHUj5fkyk6QGsEZ7xTZD7xGx6tM7ZLUp3nLDf2j+rePwZsUlEAQ+8tLEyrTY9Nd6RAMxHKHMryOgRgztQvk48ptQCJELPvL3pT7xHhxGz1V4gMYqrY80Eh8wq1gvZebHoP9W7EzKb0Lu2NhATJ5llNXHIBXk00uXUgJC34f3NLBePeQVJ7eUFbqc5wcjWH8V4qugZzshTg8aF8pRvA6+ipAapUncByRldIaeP1cPwey/qkxot8uapw15phgv9jQW5qD4xe+H6Pp8PpOpMKxFgIDlaKniSzqVR9Dg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1FKIWIQj28l4r/OxXd9CbVdqZTv1CZEHb6kl5OWMX3yPxU1gY7pgwc9rZyvLp+i1z3sG05PzNVn+VPsl6sPw5CVUJV+XYQ2ZZw2dO7rZZRyJloyRJDy3HhAgCkCfBztQ68hCnwVOxe3BpSmQqV4lUIxke4x0xC9DyWC/kalVdJlAMEFqwSS5jG/JgGmxkYg9+roxDyxOBB9gK3U/Qs/4mr1T1GBHK0Y5J+Xkx0qI+LyTaZw3BVnWNSYDIXg4NbyUUUm679JYx+mOsZBL4IuU+T1+w5t0FPUiWFwPoBfuos0tZjIw2Y9ZS6zTn9B+L8pp0ztjUfK+ecnT6tw+aHB/Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 19 Oct 2022 06:50:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3WMp8fkwGFUvPUGj/zptqNRTAq4UNRwAgAEdejA=
- Thread-topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
Hi Jan and Wei,
> -----Original Message-----
> Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code
> from x86 to common
>
> On 11.10.2022 13:17, Wei Chen wrote:
> > v5 -> v6:
> > 1. Replace numa_scan_node to numa_process_nodes in commit log.
> > 2. Limit the scope of page_num_node, vnuma and page of numa_setup
> > function.
> > 3. Use memset to init page_num_node instead of for_each_online_node.
> > 4. Use %u instead of %d for nodeid_t and j in numa_setup print
> > messages.
>
> The only instances of nodeid_t typed variable uses that I was able to
> find are in dump_numa(). I guess you can leave them that way, but
> strictly speaking %u isn't correct to use for nodeid_t (as it promotes
> to int, not to unsigned int).
Sorry for suddenly jumping into the discussion. Firstly thanks Jan for
the review :))
I am a little bit confused here, nodeid_t is defined as:
typedef u8 nodeid_t;
so I think here %u should be probably fine (I may have missed
something though)?
Kind regards,
Henry
|
