[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common


  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 19 Oct 2022 08:46:12 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Lgyb00FqAeO12JB6cDVClauHNkexfkXc7WQaudLwA8=; b=nT6nWq1ErxU8TXMpA/oIZaWmyNOQJjiWfnV0N5t7uUKKAW9jURCuEhyZ3iXu1XIKecHnoNYiF5RVl2TTsOvtTzbrVJLcpfE4Dx4kRs5TVebKldpV+3L2HkfRzms2nDdDAMj1mKRHgVJhSnHUZYkWapKL5tT6YkcoMYmSafohBykjH4y84rbYp8K2ImN+P1NRZlJ8JMQAXq1Y7zfhvpa5p3F0sUyzK0tDeUc64wwQnG0a8OhRKKZn6yIzahV3a2rvTo4imMFd5WH16TXF+JDUw+4yMl/cbSzKml5hzCUTbjUDhmvSzdMVbUMl1U6ens0zTXellhFsTscnpwBk7tWPgA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZC6C/MUuHKJRncUWlqiNXXNhg2VVkKxSmPW86NSSTYoVkYV9sd+Z4I0vGebAO59+zDNsRnz2l7LyGyTZ0q8s5AIBNSYeo5cf0LnTOLm8w3Wif+94GcvqCQW5QqxxbvBBqvz10yyu0EbE1jDszPVAwZqys27UHUyt5vhULIX20xUuZxRpJDv+MOS6T029pBr8UiOWMdIWf1zKunoFEPMEMAuf823B0I2KfQkYf0YHHroPeOxFg5PItVPxmRje0pc+o0BOMNRq5aWFVSd5HV6EAsLjkn20anWTK14xQUcPcv46kxsWdcudhP7V5H0pb/qRqAhQl7xALJFM3LXUXdeGhA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 19 Oct 2022 06:46:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.10.2022 03:58, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年10月18日 21:46
>>
>> On 11.10.2022 13:17, Wei Chen wrote:
>>> +static void cf_check dump_numa(unsigned char key)
>>> +{
>>> +    s_time_t now = NOW();
>>> +    unsigned int i, j, n;
>>> +
>>> +    printk("Memory location of each domain:\n");
>>> +    for_each_domain ( d )
>>> +    {
>>> +        const struct page_info *page;
>>> +        unsigned int page_num_node[MAX_NUMNODES];
>>> +        const struct vnuma_info *vnuma;
>>> +
>>> +        process_pending_softirqs();
>>> +
>>> +        printk("Domain %u (total: %u):\n", d->domain_id,
>> domain_tot_pages(d));
>>
>> Perhaps switch to using %pd here?
>>
> 
> Did you mean %d for d->domain_id here?

No, I did mean %pd:

        printk("%pd (total: %u):\n", d, ...);

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.