[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
- To: Julien Grall <julien@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 9 Sep 2022 09:13:30 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=aHrIZF31GilfYc9ahg8QmyoobrHQGjIavJi047zo73wPo3ER8qULM6tRbjuup+hee9X6rtUTf443QkZxd1/+ZT4M1zw1ZYG9k38X1WArlH2aiQO9UlmaEm6nYif7Gw1p65GQFyU9VK4Ddb22hvVI+BJ0rmvKG2l91VkeNhME3TQ7wh4lWYfkxthWwBuv8+YJ5K7rntj2Nvuc+C2DSXBzJNLz+KI0DCC539oaGxM9MrQBqf6GNMRBBclrjmiW/SNQKsIxSgTjroebcM9FDZYFMSJmaQTbqMRd97EgItdNRHR8EoCyeAo9VUK59KNl3DEUfxH3iN/Ybo1y5v4x1qDIDA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsW6TVLehl8VTt+ux5yytFTBdA829iehgwRc/kKAIhc=; b=kValUNtVidSSpGqYJFglpmifusKtb/N58lQHHnAIqe5ZkVDXmzIdp6TypF+Vrl6s4srCt2FWkElGaBR56RjS6GiiF/l52YafF9duEXCXEIDDRPYHR9EBWC1wc0Md6HasisKAyLkymwBkgyGd4zJct4zMW4AYbHsyHmiYIhO5MugLKJwwOgQnWmgOwXH4QlWuHa9bLuAJF6/sIhMx+WN+LiTLqUo5pq9aHDV/8hXRdDAtzAwisCVgr66r1OMnVzXA3986kXeEr9Dncc1UuAyKcLyba8Tw5ibGh6WEhtuCWIrXeAce/Kuy5QUkMaa6YMuOoKgFs99a0LOb+fKjUYTKnA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TRdFxuKhjHOLppBoNGnBZSMwraauAzBEmtSchmHJQfAURwEz7qhdLZcx0Om3hp8QNqv9d9KLHHWFLP+kaP7IuoQsncytAPVuorUk2es/4NaiKima6KV+2mO9++3tu+nTsbr1nM6IGP61nNMV3asqOQ9ZP+gYOPSkRe3DqYlrSurffdl3ZD8IOtkaAlYDm4Hird8kvkFg44Kg2cO9lQWS6VZzTs0drTKwb5sbBWkmETAosGxOZ+f6KvnoQMbA4bPhwFtTT4OqENewaMb4MTJ2lNm8r2GBQ3JyyX4V5jao10RDlRb+GQgaETza2dkBU8uaM5LhA3K4gtv5wvH8uLMyrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsoOCIC/MQIc4YdXjQRJBRQx62iaaW99f9I9Nb0ozqoTajJ5NPPl81Sy2wcHATqLEZ4Z7zzMWjG9CCW7jU79jFcDqvrFOAIKOH8c7RKrhbZaOiyrhLx4/VOv98uq+3hyfDO+/cTvlbANqququGwa6dZFAa2PiKSfKadZiGNM34VQe2tpvBnJezXc171Dl6JWoUXlgoNAqe7ivisQnqIzxl6T+eEMo8gUWgKSdtzb4MLiHUMV/ej7b7E2NVW0SCPW/1K+2y4qm6HKW5bhOioJo0r+9jn8tnYGl94df9lXQM/0myfSaLkFVNPxMmY4+A1UCIarb1usqQXg7b6iej7VSA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 09 Sep 2022 09:13:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63Wx2cggAAGtoCAAABn8A==
- Thread-topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
>
> Hi Henry,
>
> On 09/09/2022 09:47, Henry Wang wrote:
> >> -----Original Message-----
> >> From: Juergen Gross <jgross@xxxxxxxx>
> >> Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
> >>
> >> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> >> warning") was wrong, as vaddr can legitimately be NULL in case
> >> XENMEM_resource_grant_table_id_status was specified for a grant table
> >> v1. This would result in crashes in debug builds due to
> >> ASSERT_UNREACHABLE() triggering.
> >>
> >> Basically revert said commit, but keep returning -ENODATA in that case.
> >>
> >> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> >> warning")
> >> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> >> ---
> >> Might be considered for 4.17 and for backporting
> >
> > Of course, feel free to add:
> >
> > Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Unrelated to this patch, but as this is your first Released-acked-by
> tag, I wanted to check the policy going forward.
>
> From now, will any new patch need your approval before been merged?
I would say from now is a little bit too early. I think maintainers can
still commit patches (fixes and not new feature related) until the code
freeze (end of this month).
I am providing this tag just to show I am happy to add this to 4.17 since
Juergen mentioned this in scissors line comment.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
