[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
Hi Henry, On 09/09/2022 09:47, Henry Wang wrote: -----Original Message----- From: Juergen Gross <jgross@xxxxxxxx> Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource() Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") was wrong, as vaddr can legitimately be NULL in case XENMEM_resource_grant_table_id_status was specified for a grant table v1. This would result in crashes in debug builds due to ASSERT_UNREACHABLE() triggering. Basically revert said commit, but keep returning -ENODATA in that case. Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning") Signed-off-by: Juergen Gross <jgross@xxxxxxxx> --- Might be considered for 4.17 and for backportingOf course, feel free to add: Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx> Unrelated to this patch, but as this is your first Released-acked-by tag, I wanted to check the policy going forward. From now, will any new patch need your approval before been merged? Cheers, -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |