[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 9 Sep 2022 08:47:56 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=ehklOCvQZ1jUXiu40ON46JxVRRf3t/gGRbF49/BoBvy2tE37KvJzF3+W9ONk7j8jS+/ewp0njOj+iRo7ST/Ef8buTupIKU6VpLkpWs1VYPDRG5HIu+E5H8pPgGfiXDELOfPN4ny9+FiG+vkiCNpGhxH0ascssHxOaNyyXWKE8lrx0ZebXe2pe2vYZPeZzKzasZ+fakmDU+yT66jBRQXPziYOn4w5w+3+rbWN+O9gBsI3qx/8W9K0ChkyaMPVynXHS7Buta2wUjmQ9g/uQtTo45JGq2d6xHaB3rO+8n9BCpZsU6UozotH2In/YgwqwSaTYfm/nRzKWIyQXSr1gaY7DA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dUFCoM03gkskNqqdPwVSdN/jE1pWbq6byaxesKdkOQ=; b=UZc/eoRaFPEyP6s0VgwQd9+QbQjFJY7kCjXsYLh0L44agmxPo7jziTRQF3XE7RRZVHo/LKloBbcUfl48PIUACZ1Vs8l5O8q4FNBsu6wGSn4enti9YzdIm1PMGVuI/lV3cQXmer6Ab2+XC2cQd2l/KvCcZJnZYqZDgl56Zg7M5Yhg1t+0c1wzisPxbSQ2vR7cvjE5f5RBQ936WR1GH6vrB0dTinIAeB/nimLlwTuSY0ppTDDHbb+kMdnc5D6wQyz1HCypDf6o2w6jsRotlbHYaY6LuOl54jlMiJs7oEYAOEOwO+cbaki7i2KYIWEmk1pLbIV8aO86JK9aTqeO6aVDeA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=I8a9UnKVbTR85PvoEVhbLae/AVHvVbyFw7rXgoYUGNBXYoDySuI9fX0UklJnDNtPIs8EvIvQRSp+NNV9Z6Loyx4k8R7DY8ZwgwZCpTS0IxXjGVz18GSAVeEFP76iyyr8Xi6WDyZOjJbe+HNSx6i8wv6ZAWd7b6X7aaGasLZBhgHfUYgPi5U3n6WR+H/ENILi3aXsRJptOyhKw47R1UzEvTYKGjUQbNNiZpqQSTYpM12ujrFVDRtdctVQQz9EEpEp36xjzRgtDzStiqtFKY6cU5DDAtoNY8eIDDzg72CXpGzaWV/fOL2431RcL9bAr71q0xNeZRGTv5ngJNxLjW4gWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2mEUgGFw9e0diKB0OK6ux5fRjV1NkRtwy/nZaZ8Me9xnR6eWptGZ7BnXjlqqaphmm3UsC0V5uBDbw9HK/VWN/W+7uaDEBkokCgH6PQb05/dOxIbztEIOk4b6s4ZBnaG8TP6f7ELrXQl1D9wFtL8jauKfOYOxjaWIBZtWXN4z4pybSPaQxQjrHDXEkgnw+YQrEG8TLLdqzI43CEBIOLqXXaKQeDFFeO4yhohkzqaZhzQweBylCx6MFAKdOHSTeskEE5dbzCQsP8xOS+fey6k0b5H0zHm091tmkCTd9mr4SCiUD/n7HT/uQnd6peQgFVs35hfzcYbPqOx3wfrHmVYCQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 09 Sep 2022 08:48:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYxCOLeMow4nnAdEmRQz42iuSBI63Wx2cg
- Thread-topic: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
Hi Juergen,
> -----Original Message-----
> From: Juergen Gross <jgross@xxxxxxxx>
> Subject: [PATCH] xen/gnttab: fix gnttab_acquire_resource()
>
> Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> warning") was wrong, as vaddr can legitimately be NULL in case
> XENMEM_resource_grant_table_id_status was specified for a grant table
> v1. This would result in crashes in debug builds due to
> ASSERT_UNREACHABLE() triggering.
>
> Basically revert said commit, but keep returning -ENODATA in that case.
>
> Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized"
> warning")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Might be considered for 4.17 and for backporting
Of course, feel free to add:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
If the maintainer give an ack about this patch.
Kind regards,
Henry
|
