[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Sep 2022 13:31:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=NevV0C6fihSC6sDB+0uzwWNeliUNdpUYrPwr41unYYnabMIb1xyMhzu4kklL2cGrJ0v3pfQ/nHg8ABqsY22bkOJPwbWD9t3RnS6sLcXXUSboe27FD1I+tEbHoVYhBYWK4z8+R18CeTp7QCUzgWscqHnySgxQt948SDV8UWWcz0k4WqlJfjRHCGdXrxZkCuk2AKZx82iTIYDXKJFL4VOFfuYZmNk2fXR9aj4LuCB048+1lXOxcm3Oj06byggtlysyvW2kmLZcaGxA3tzWw1srrjf9tezt0B5efAcSE9EqMpIFk2hF/h2Ezz/lMVHdrCRyTVxHnFt/NEy/ZDwgsJATNA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHbEvZg2VmQdh1TU0dT7zEuTcLScvMknWkhUXNuEiuo=; b=AZnPD06TGcjXTbIONoZA5wYeBKsW29gPFCTALQjSGEJi2vYfgZqtY/0WbjZZDXPW/j9xT/l85maZuS1Uy6lhR2Afab/l2Qv/kWyqncbY/fpc2noqbCD59kF4To5YLtdOrhF46xP7wDMp4iFX1OqE/iNNWRcQ/xFSmk9ogirW/94fkb8yFiLzG+bngkJzRf0hte1fyNIx118KQVfcVrTwGrNySBQB2kDUZAC6IOAEP9HgBl9kWVEFiZWskLkcEgzXqlp75Cfp39Utg4HLb6CKQ9oHZItTioApmUgUHE26LAXmb5ELO67+shI/1pF0QKEMnKxYYc4JVL7ui5x7irVpHQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O5+ILeZm0MiAzA77IlkaFeUJ8r+B3amUhCVkViRVwmSxj8oKDOJb3fNcqA7/Zks7HTnUlVr71BNPNISaOxkZe/jn6do/aexoUsJRLG1uehfaOJs4GgBzVjxBEqnQvfPqN6E25CGFordtDNu/TybOI5JS90Nx9rhhbujJ8y8gNuyyNm4+kimAevS8lu7IrH455UdSE7OUou6X2MWusECWGeSwdhCmaTyO/ASd9Cw1FVOjk8Asaje4RJsNrS3mIHl2PaITKMJumYGSQXf/xypYETb7KQRqgSrumWSklJ8g8ZR4/Vk3ilrjXK57LDwJZETQJgE6bp1t5euZgupIlCKgHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bf9r0MKZwLDtieSCsaGuf8Zdxltb3nUmcXCze5s+yp9HvRS5FhyQV1oqpALFCQNdk9pbf62/tftx8lkxCoN0tc2Z58BqKbjDNqNqn7BsLX5dXWT1iYH4j7oaP6P8ft+kt8lJUWuxTU9vVSvvolgTYpsFThTmsnyJtwvuhJjyzr1bf22HzZNqhXVCodIvbV9b8FVmPIosZNoX5XiejaBjstmANG9BOHMtn/47dNtizauPAxNQmpDxAdceM7S1EYXsg2bUysHHRLE9r/0rET0aOeZ3EGJjz9NGnTX41mIUG44q0Uylq+lnsX1TQHsKIggN+oLFpUtu7bcJMhNu2Mlefw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 13:31:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwqqLAtgrk5Z7CEC9g3vN92mek63T3yeAgAASqwCAAAJsAIAAAq2A
- Thread-topic: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
Hi,
> On 7 Sep 2022, at 14:21, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 07.09.2022 15:13, Bertrand Marquis wrote:
>> Hi Jan,
>>
>>> On 7 Sep 2022, at 13:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> On 07.09.2022 13:09, Rahul Singh wrote:
>>>> is_memory_hole was implemented for x86 and not for ARM when introduced.
>>>> Replace is_memory_hole call to pci_check_bar as function should check
>>>> if device BAR is in defined memory range. Also, add an implementation
>>>> for ARM which is required for PCI passthrough.
>>>>
>>>> On x86, pci_check_bar will call is_memory_hole which will check if BAR
>>>> is not overlapping with any memory region defined in the memory map.
>>>>
>>>> On ARM, pci_check_bar will go through the host bridge ranges and check
>>>> if the BAR is in the range of defined ranges.
>>>>
>>>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>>>> ---
>>>> Changes in v4:
>>>> - check "s <= e" before callback
>>>> - Add TODO comment for revisiting the function pci_check_bar() when
>>>> ACPI PCI passthrough support is added.
>>>> - Not Added the Jan Acked-by as patch is modified.
>>>
>>> Hmm, I don't see any change to the parts the ack covers (x86 and common),
>>> so please re-instate. I'm not in the position to ack Arm changes; things
>>> would be different for a Reviewed-by without scope restriction.
>>
>> This might have been clear for you but your ack was not mentioning anything.
>> As the newer version is modified anyway, we remove it.
>
> An ack can only ever apply to changes to files the person offering the
> tag is a maintainer of. Hence there's rarely a reason to scope-restrict
> it. As opposed to Reviewed-by, where someone may indeed have reviewed
> only part of a patch.
Distinction of scope handling between ack and R-b here would require to check
in the MAINTAINERS which parts are in the scope. Maybe explicitly putting the
scope with the ack could be useful here.
>
>> But I understand from your answer that your ack is still valid for this
>> version.
>
> That's correct.
>
Thanks
Bertrand
> Jan
|
