[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Sep 2022 14:06:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CiFKFLhAOtg2fQoQXjIEOUXAKLH0r3SrJjrjsvl4+Fs=; b=CYAWzlABxqHXUdjvG3sWAtevStOVOO3G3sBnN+pjHCZyqKVQA2dWOoF5u92x5g0iEE9gxRsPVLuRcQRFRREPiLjiskppwKcJWB4pjtTpAIyCgmXURvgcdINeB3JM8BsXzMSsIaVbvk1L4XUcpb+e0F0cmY+jipAt4K2h2UKS7kikA4NVJJM2k/7BJLQawLrNXeIh6yeJjMW6wSnotv4fJnOzfTc2VRblYdRkeY47Ns2AVPY7+7BnKUt872i+axEbnXEMbQWnOQuRyWYlLdsa+pEFjT36tD55U/PsRCo8PzNRHAUuMQraIhUfr0tk/i/2YObzsU9PTKYErnTlzOSO5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jz5dgdf855gE6vymuqMeMpA/zE/ZWCR4ib44NK+ukyOPHW2ZATsJADqYh3AO+Q6zSCoCVWaqGezPRPY9tvn5Jo+kqN0T6sD0GgjPJGdzlrC/juAOm9m3YuMcBlN8j822ljtKcuWb5zgu6L6bsOIDnjD3g0H3/1wjraqie7t7pJglkFEKzzvBiHeWL/wXSpoIGJPnaD+FNmOvF0mx6gQYdsiRPmlLWlQeiYJmNSZXgWnwCqNjSFdsCz7JjhwcXWY4SLRhMwjF4dmDfuezD2xhm6A/RGvAC8ynJJHF2lnuzHDOyPp51Zm0wa2VvstOlKq1P9T1InKCvXTlnvXxF3ycXw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Sep 2022 12:06:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.09.2022 13:09, Rahul Singh wrote:
> is_memory_hole was implemented for x86 and not for ARM when introduced.
> Replace is_memory_hole call to pci_check_bar as function should check
> if device BAR is in defined memory range. Also, add an implementation
> for ARM which is required for PCI passthrough.
>
> On x86, pci_check_bar will call is_memory_hole which will check if BAR
> is not overlapping with any memory region defined in the memory map.
>
> On ARM, pci_check_bar will go through the host bridge ranges and check
> if the BAR is in the range of defined ranges.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> ---
> Changes in v4:
> - check "s <= e" before callback
> - Add TODO comment for revisiting the function pci_check_bar() when
> ACPI PCI passthrough support is added.
> - Not Added the Jan Acked-by as patch is modified.
Hmm, I don't see any change to the parts the ack covers (x86 and common),
so please re-instate. I'm not in the position to ack Arm changes; things
would be different for a Reviewed-by without scope restriction.
Jan
|
