[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Sep 2022 13:13:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=VorpxneZNDTsHaYBLHBG4bIVe4bUFB5x5R8c0BDoVQHL6mBS8x2ZrQni3J2nnp8EsFAmY/caNUaZsoD6EfCTpecogA5ezMWAd51kN+2AvGvBoyryLJRnYfZCm1lWabMMno3HHclDkYDka5SJaLsc26UfRzxw/n/NRmRQAaYYKYP3IfAeyuHBhY2W1/oGgNPAuV/7z/Y0DZ1cNTaUvhO8GgSs4MsXrULTeFpPvyWsDUKIDjAn3cZzWMk1BGfRbt7mVJXuYP1lStN02sKlTPdFq3xV5Z4hFip6PyXYAr335NWX+KyLHYKl9U1OmB1IZybOlfEfvo39eGWVr2MD0tGdRA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPSZksgSqBgB1l2BBur1o6n8MHhWHapVGYMKO+qCT8w=; b=jd6NYncs4Y7VpVp/QZj/fhbR/lkIasD4oB8BVVcBB+y8iYmLyKuV6zO8ZsCSExG5Z0Y/lDIrfAAF4q9hfz/937n8igQdNP32NxfiMHIEZ6VGtTKTU9vVfQqQtwBv0i7CpYVuX2awuKMk446vCc2Amog+oYuLujcvAANRfe/1++qQzn23e1DFFXILqhOyMZQx5P5LN0JHL53cHQN8QiMUSZ1Jjbs7Vy7WmHxDggdVHYzUYbPLjE9nmMSa5hqV6u3AKcRfXPYXyXu0VV4la7hNJ5XMF39S/XCkRW5Ww2Y/73GcpjJvJjAd1sTCQCex8z+FLyQkK6JNUzag6QWpuUVJpA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VZN66kDjjJk/6KTqqYLkQt4d+qAwvWTvutXwi3r/EIXDDG50Fvd4APHhZFyUrv4DnZh7/0Zh1CqEovYyMcWpDZMt22HCr8w/slkkMsQWC9FdRxIUnBCQVQWACRf6QbQcwxTOzA2YiqaD6JfXHIcA+PsYmJmoVkjFWvrI77sYWZprpFUw+ZKCtMujytjakmCtDAYBfPFmFkrpX2uqBz+vkIKjKreX7CWNkMa31xR4JxyVhuIU7hcsGMt4XurrR2kdjZnpfMz4J/496K05aNHXPg+jownwnqPKNJaTqFdoOjRvRlh5CRdZ4x8zDH+RX/XTafqrUZ808CI7zhUr2k53bA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtnPNcIWGZtOlvem5t8/dOzl3K30U/1wK0ZhXbEzXH8LIulp/1vIbKHjAE1fWDKK1M0gamKw7phiokhdIAHcC8KP3Fk28jm7OHhsh4ZRqW5cWgG6nPiBXU6oS2DTT0C5sp5BVwRJZ1K3tdTTD4CF5UYAFVVr/l86DfsEqygMfetGWbL19pA4nSyFdJRaLPJZGTmUQAItKo9PwOe/HtocP8sKgo7e/n43rZucUkXlLkO0Jkck/7QGKZMj+TaNi7qAWc799k9s52BwS0CrVkfyhYLh50EaBUZYwFIO8ahePNQuXpGx7typ8lhVoyuLFHf6iQxZGD+TvWnQcumSc3baRQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 13:13:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwqqLAtgrk5Z7CEC9g3vN92mek63T3yeAgAASqwA=
- Thread-topic: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
Hi Jan,
> On 7 Sep 2022, at 13:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 07.09.2022 13:09, Rahul Singh wrote:
>> is_memory_hole was implemented for x86 and not for ARM when introduced.
>> Replace is_memory_hole call to pci_check_bar as function should check
>> if device BAR is in defined memory range. Also, add an implementation
>> for ARM which is required for PCI passthrough.
>>
>> On x86, pci_check_bar will call is_memory_hole which will check if BAR
>> is not overlapping with any memory region defined in the memory map.
>>
>> On ARM, pci_check_bar will go through the host bridge ranges and check
>> if the BAR is in the range of defined ranges.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> ---
>> Changes in v4:
>> - check "s <= e" before callback
>> - Add TODO comment for revisiting the function pci_check_bar() when
>> ACPI PCI passthrough support is added.
>> - Not Added the Jan Acked-by as patch is modified.
>
> Hmm, I don't see any change to the parts the ack covers (x86 and common),
> so please re-instate. I'm not in the position to ack Arm changes; things
> would be different for a Reviewed-by without scope restriction.
This might have been clear for you but your ack was not mentioning anything.
As the newer version is modified anyway, we remove it.
But I understand from your answer that your ack is still valid for this version.
Thanks for this.
Bertrand
>
> Jan
|
