[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: acpi: Include header file for version number
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Sep 2022 11:14:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJBDFeUPxgfJcf58l/RfdXZoig3p9P9YSHMNrCL7twU=; b=PMOS9iQriwFVAt4c4ksn7+1Xg+MmxRW+3H5j5ZvpOX3GqaI8+w3uLogLuuucwzrzoSiETNFp6YOzvt3qGMIXf8eUobMHhF1oOk67K3z8DhNnD7gxxEgYynoWfAUv/hQxeTBs8174s3rHtVbPyvGm06hnZt0ouAjK1dqa1sJyZEYg6js6pNCSnflosYq9b8jn1RsmNroyqiw/zYz9PxUZaFKDRETmFTqX0Cgy5V+ISXxUXzxOeQMESSrh804Y7YJGHHOANNt+Rghp9rCyqqpFSGA3WWynbD1o8ARyc60SWKS8SbLd0kBOTOsng1IaNqSmUhR6XhEOEiLc4z+Z1jBdcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/AwbhLLJ7PzPQmj6uCizvVh09kOHePBDHu8Vp/v2oyxtKjWtJW2uHWOiwWid1VOzoKBC1Owho71Tj6QF6j+IhSgpPj37WuYNUTaKpr5K5RCu7nuTZwSjbafhsm+HztTkPjJTqmxGTmJSLWcGKDCar8H2tsfzZdXf7zpV+PN17smnr6lDOrkquwmrZ+4TPSinlGEX+DPdJMygSlNlTU3oiebwWssa/KiNCUjGmfrgSFxrae92JJXiPB4oJK073/YT/C6hvPj8HN1/3yeDtyH7MB+j40Ym6fWgXjKAOIikH7mc83z7bTlgOox1DICPS5ax5MyKbPqFoxefJv1VblSuQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 09:14:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.09.2022 10:58, Bertrand Marquis wrote:
>> On 7 Sep 2022, at 09:55, Julien Grall <julien@xxxxxxx> wrote:
>> On 07/09/2022 09:53, Bertrand Marquis wrote:
>>>>> Otherwise if we start adding those kinds of checks, we will have to add
>>>>> them in at least 3 places in xen code.
>>>>
>>>> The solution I proposed above is easy to implement right now. My gut
>>>> feeling is tweaking __stringify (or else) will take a bit more time.
>>>>
>>>> If you (or Leo) can come up with a solution quickly then fine. Otherwise,
>>>> I think we still want some hardening for backporting purpose.
>>> I think a define in compile.h using stringify is the easiest solution:
>>
>> Ah! I thought you were suggesting to tweak __stringify. This is ...
>
> Also possible but a bit more tricky
>
>>> #define XEN_STR_VERSION
>>> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)”
>
> Quotes at beginning and end should not be there.
I have to admit that I dislike the STR infix. I'd prefer a suffixed variant
(e.g. XEN_VERSION_STRING) or one omitting "string" altogether, e.g.
XEN_FULL_VERSION (albeit I see "full" as being potentially ambiguous here,
since one might expect that to include XEN_EXTRAVERSION as well then).
Jan
|
