[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: acpi: Include header file for version number
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Sep 2022 08:58:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=FP15wW7KJUePFjK9MohGFyJkguvT5J0bHwETpmfRRlD1Y9mRWfTm/m+t/+zmpskTHdc+x1zLtbKAvY6nB2eCVjJZkihdaZgrv2qd4UsTh4OdHgeA5kmG7CExEjOBYuHLA+3KZNDkR7eYUxbg+gVKoL29vtxdynJvp1vmmO7dR4tjt97YtAQvh6IjiKvtBCT4FaB4HswIXXIJ8hbvs3dawsADWrpmeafhRCnPzkFD63V6Ka4NLkcxTGuv9Af9xbuZXN0+XeyhlIPo8AdnfUHUwBDJQDvOf6bbhzoOWTgVgWx2ifAZEvzgXzZ+pGYfXL4FI6BDyh42Si3J/TV7hNiRcA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTQalHre8kTdyfkbsxNJMXTvI9LYbIR6XJrpzwLJI4o=; b=JgjzlPXCcNnqieVtD+bzT8Z9VGmLF+Z39pfZe1Qk2KimROl5gkINjNpB7q9xp8g5KE76rlxjMcTZdji47UzifUwT18VXsnqqNIAWwsITetr7dIYp6DtNiWTeNaSvHJwYr8xIjZRGzdQcE1QBYoSn/HcXykfcC6npNGYoaQRnIO1bjnB+vRWa3FPhjLuzCFGbz8cViO1Ar839rujxLtlBbjFpwaSmvwaXVJWLh+UA3Q7kdBAnw6rBnYLpjqf2F2jIf3t9KwzdMBrYvvLr3fGjhJ2ZWc/TY7tbhwKlhgMVMsS8CIWIu6l0nasPziWQtQlTSA8LcOpFwOeLu8wLrnvtNg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dVe+VuNkzcYEIHg/UgvxOAXT240cQKJEXmZ8nHLhxRpauOkRyiQtl3Hp+4lUgAzSdyOJiFZWTWzT+xgX+BTP1lMvfbZ+1S5wNXEG7qEZoyo3l3oZW5uiMzONDrNSNbWU1KxHU2cKaUwteG9w3GU6zrxj+69viqCxBTzShRkcRR+eJRZOd7z9G2B9Qu/6njqRKjbIAtWSAkgRyCV7wCKMXyboaTFWUmqNI5Q6eKBR5B/WSY24zaXkGcljHNCoX+hDJGkhQ4hdkodYPr8JcrPoUhWlAk8fqfn90jpAjIHhD6DO8C9Z0uOY26q0AUXgID4Dya0kTj8peNgJYicV3S06Rg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgNlEuP9dRBu99p7fwR9IGcQsS7AbDmvuS5e6Ha57/vCLlsSNNqK3xnMkRQ8SNgeM+/RyXIXRHRHqzjuSnQ1vRI1hOdAKR0QRdaX6ypc/UgUo0A+CjjEHH8+ER+LUaFg5Cq7asgOvmnlVLzrDKadyPb/Ki0l5x5OSMjF4Ygc4YAxygb+6NBE2bljclnboDHrbpuM5ru2G4c4/fJQnzK4aInjVfHDnFPnXNArpRtoL3MkdylDHaCu+NJT+gQvBaW0TtuUHArOxpzQGK3couQm+9j0T62wWnAKDW/0ZIHdZBRxqhWQrgOvTuI6N7Q686IJMRceEPaJSNXDkLDcbVTyZA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "leo.yan@xxxxxxxxxx" <leo.yan@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 08:58:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYweQzyVikzADCFE2Bfo+zYT5rgq3ToyoAgAABNgCAAAHYAIAABH8AgAAAyoCAAAC7AA==
- Thread-topic: [PATCH] xen/arm: acpi: Include header file for version number
> On 7 Sep 2022, at 09:55, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 07/09/2022 09:53, Bertrand Marquis wrote:
>>>> Otherwise if we start adding those kinds of checks, we will have to add
>>>> them in at least 3 places in xen code.
>>>
>>> The solution I proposed above is easy to implement right now. My gut
>>> feeling is tweaking __stringify (or else) will take a bit more time.
>>>
>>> If you (or Leo) can come up with a solution quickly then fine. Otherwise, I
>>> think we still want some hardening for backporting purpose.
>> I think a define in compile.h using stringify is the easiest solution:
>
> Ah! I thought you were suggesting to tweak __stringify. This is ...
Also possible but a bit more tricky
>> #define XEN_STR_VERSION
>> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)”
Quotes at beginning and end should not be there.
>> And then change the code in the following source code to use it:
>> arch/arm/domain_build.c
>> arch/arm/acpi/domain_build.c
>> common/efi/boot.c
>
> ... much better.
Thanks :-)
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
