[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int


  • To: Henry Wang <Henry.Wang@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 7 Sep 2022 11:19:00 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OMkUD4kdRzoyJFP3dJbCO2HK4yhpZNDxiqLu8+myk/c=; b=RJZE1dhtHhy+MBb+MfTYLOynd1cv5cKVbhiOD0BZRVpSDyWv9/K92jmhXrVqEBsQ8Mke0xEa5dZNfayAzoScd5HKOkOm+j+WNhRRacohi2PeLz9ctoES4nMAi3Qjo0j9Nw6S7LZJ3ctBIY3n/+iR7N/Opg0Jl5ijFc7rLPmKPSgDDuW9yUy3u+9qkbRgHWbmooLyQblEejqH13XZdYG/a0RPEt6KzDH/LlwKrzJ6Q39x7/3PM6zRnarhoBwbXOnB2JRHlxfX0fpy1ttrBcum6xPgkxMN3HhF60fmvArLQ+OS726zeXdvMKIUhsf0VEihiLpr7Wgc2BAU5th5Qqf/FQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTbWXUXMAnsiWmvgABQp40E0J8mC5hTr87JO95eszGApjd8hIeVqUuIDSnT/klkzANf4XUwy7buo02+3k+gezhfPbVigyYTtbRzB0Y/dfjQCYmLaSjK0Uz/svzyBubM9I2nkR1nQfMvNNVhtlFlUGvxWlhL9IOvTnJnx2IeevV77XBaBVEQ+bl4PMOlAmxIRJAgOX1b09cGRmmr8mvjq3X+WESfEfvaK1oXXDlumqyahML1pXYLO5EQzfZQLYslpkK4qsiEl6YyHwN0znMJdflE/b7ViMIIK/AYqrXXwbN20gIYgLuQE7Z6jpqMkx5ljW2mOl8lajtfTJ0uxvAYLtA==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 07 Sep 2022 09:19:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Henry,

On 07/09/2022 10:36, Henry Wang wrote:
> 
> At the boot time, it is saner to stop booting early if an error occurs
> when parsing the device tree chosen node, rather than seeing random
> behavior afterwards. Therefore, this commit changes the return type of
> the process_chosen_node() from void to int, and return correct errno
> based on the error type.
> 
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>

Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.