[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int
- To: Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 5 Sep 2022 09:21:01 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=RnAr8AK3VH5w6+XUTlyr2aP/s44FzmCk4YVJGl3MBDg079HJDc4ifkOHGBX7ZfHSjXv3DpP3jqEx0sVVo418jb22rIHtewNToYwbOFY7lulpxu/QQebERNVBranLVNQ9swXmBV3EnBjZlKTf85GLPsfG4GuwgIhalWD6pj5CSoby0Fuwf3F89KREMvKNX89CrFRI6qJ+Klja4ZOXJofRx0gu8sjbNJxCN1yzfkzPPIgIuiHmtjgHJ8q8ZOH7SNkSjxA1CoVvaYBFwstrcEgRo840PUrw9ozOkc/Dm69+3PxilaEIPTJ7qSK3Ia0jLenzCWroAgzJau7CCJG5Sy6Juw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alDDSy3Dus7nIEmIncxGZP4cuawpPGwz/Hp4/9DrTt4=; b=IyLAWCfvyuGV7J6qwwWk5+Qrd8nSQwI6UYMvPrNaZdiHKfHN5mdqF1Rp9PFAiQoEyeiSMxEMepGMwkBo9j1nLTVi6JM/BYB5s4nJ8/fZ/IsiYmZRc+61xtg/L0TeuCcPm04s7xACDzuCMnSW0PPJm5DbxEht/GVI+M5ZzohhzAJ+KrhjBJ7HTzGeFdoznJGIigroKxIAengGnPe7prWoQPJPl2/lClbPTxAgBZlB8ls2Ie3qhtI/MJNMCemd7G6iL9bVnCnd5BTtkGK72TMxuYUgleZWiyw+8WRuByhrLqoMcRUgMmhNKRxnTt0xO38NhyT8nVbt1/Zeh+uuY7lAKA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oWiJbPR1WxA3OyPn66YfBvikfD8QdM0dv+Qr+koe/vFYJlny/R/UTP+SktixVgln74Seg1n2m98Hqu2O4okaRsyWIlfRzyOzSvSkElfiqnqhaDhCF4DPQE9gGWUzvm52BBced6GBvajBlcBIzPdIyGREN+urvsrJxN0CJv3biywGJBWG2UnG4B9MRV+u5VWOdItG5VCeiARg+oesA77MiTcqg/euawU12gjnshO875B6aCHTqtEWrZlag1BGXbgljEFuiPio7ytOj5+AVLbDO87vxzpw/Y4D0idN74oxqdJctO+GBH9dsO4EKs0/5SIyscHr7KIE9qJI5NTEKymx1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lovgu3ozbg26JKNfSu7ebG8/1J/rmIrm1d4eGptyBQPVg5hGrZ3oIQjLf8a3WB/WooVPJl+9Y0tfXaLPV8gfXTm+nuXQ4plVi2sj4FOiHHN88MmvSQakyiJY3e+ttUsyAEsjvcI67fNdo3P/mmZfPJ7kJFZk3YtOj1sc/Gi8QPkBj9+xqXGoYPytP6lEj3W/+EUTsJ52iImj9t4NaGlJtdCkaTYEXLiivxUWRQSHOaywDVBDy18Sob+pffwWlEmG9KP9+mlFluqb1S58YtMLe17rCTfBWjzbJOKI/okJiAryO1sNiiwP4y502zyQwRVok1A1jL7tlL2Js4cJTaZpTQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 05 Sep 2022 09:21:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwPjyVgMKyZ6Cs020VCbItAD6Y63Qjm4AgAAAZYCAAABZkA==
- Thread-topic: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int
Hi Julien and Michal,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> >> Changes from v1 to v2:
> >> - New commit.
> >> ---
> >
> > The patch looks good but I think it should be put as the first one in the
> series
> > as this is a natural prerequisite for the introduction of the reserved heap.
> This
> > will also help not to modify the same reserved heap code you introduced in
> the first patch.
>
> +1. The same could be said with patch #4. The renaming should be before
> patch #3.
Cool, I will send a v3 with these adjusted. Will send after fixing more possible
comments for v2.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
