[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] xen/arm: bootfdt: Make process_chosen_node() return int





On 05/09/2022 10:16, Michal Orzel wrote:
Hi Henry,

On 05/09/2022 09:26, Henry Wang wrote:

At the boot time, it is saner to stop booting early if an error occurs
when parsing the device tree chosen node, rather than seeing random
behavior afterwards. Therefore, this commit changes the return type of
the process_chosen_node() from void to int, and return correct errno
based on the error type.

Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
---
Changes from v1 to v2:
- New commit.
---

The patch looks good but I think it should be put as the first one in the series
as this is a natural prerequisite for the introduction of the reserved heap. 
This
will also help not to modify the same reserved heap code you introduced in the 
first patch.

+1. The same could be said with patch #4. The renaming should be before patch #3.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.